Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbdHUJk7 (ORCPT ); Mon, 21 Aug 2017 05:40:59 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:45192 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbdHUJk5 (ORCPT ); Mon, 21 Aug 2017 05:40:57 -0400 Subject: Re: [PATCH v2 1/3] i2c: davinci: Preserve return value of devm_clk_get To: Franklin S Cooper Jr , , , , , , , , , References: <20170816221715.15027-1-fcooper@ti.com> <20170816221715.15027-2-fcooper@ti.com> From: Sekhar Nori Message-ID: Date: Mon, 21 Aug 2017 15:10:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170816221715.15027-2-fcooper@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 14 On Thursday 17 August 2017 03:47 AM, Franklin S Cooper Jr wrote: > The i2c driver can run into driver dependency issues if its loaded > before a clock driver it depends on. Therefore, EPROBE_DEFER may be > returned by devm_clk_get and should be returned in probe to allow the > kernel to reprobe the driver at a later time. This patch allows the error > value returned by devm_clk_get to be passed through and not overwritten. > > Signed-off-by: Franklin S Cooper Jr > Reviewed-by: Grygorii Strashko Acked-by: Sekhar Nori Thanks, Sekhar