Subject: Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP
 keyboard on reset after resume
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ben Hutchings <ben@decadent.org.uk>
References: <20170815011942.395714306@linuxfoundation.org>
 <20170815011944.259471330@linuxfoundation.org>
 <1503086568.3688.28.camel@decadent.org.uk> <20170818225055.GB6159@kroah.com>
Cc: Sandeep Singh <Sandeep.Singh@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, stable@vger.kernel.org,
        Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>
From: Sandeep Singh <ssingh1@amd.com>
Message-ID: <6ee13b12-ef75-bd8d-868f-b17158654a21@amd.com>
Date: Mon, 21 Aug 2017 15:25:33 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170818225055.GB6159@kroah.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2017 09:55:52.2903 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0060
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1349
Lines: 40


>>> From: Sandeep Singh <sandeep.singh@amd.com>
>>>
>>> commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
>> [...]
>>> --- a/drivers/usb/host/pci-quirks.c
>>> +++ b/drivers/usb/host/pci-quirks.c
>>> @@ -98,6 +98,7 @@ enum amd_chipset_gen {
>>>  	AMD_CHIPSET_HUDSON2,
>>>  	AMD_CHIPSET_BOLTON,
>>>  	AMD_CHIPSET_YANGTZE,
>>> +	AMD_CHIPSET_TAISHAN,
>>>  	AMD_CHIPSET_UNKNOWN,
>>>  };
>>>  
>>> @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
>>>  			pinfo->sb_type.gen = AMD_CHIPSET_SB700;
>>>  		else if (rev >= 0x40 && rev <= 0x4f)
>>>  			pinfo->sb_type.gen = AMD_CHIPSET_SB800;
>>> +	}
>>> +	pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>>> +					  0x145c, NULL);
>>> +	if (pinfo->smbus_dev) {
>>> +		pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
>>>  	} else {
>>>  		pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>>>  				PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
>> [...]
>>
>> This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
>> the ATI chipset that this function checks for first.
> 
> Ugh, for such a "simple" quirk, this has gone through so many different
> iterations, all of which seem broken :(
> 
> Sandeep, can you fix this up and send a follow-on patch to us and the
> linux-usb mailing list so we can get it fixed up properly?
> 

Greg, :-( We will send follow-on patch shortly.