Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049AbdHUKXB convert rfc822-to-8bit (ORCPT ); Mon, 21 Aug 2017 06:23:01 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:30247 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbdHUKU7 (ORCPT ); Mon, 21 Aug 2017 06:20:59 -0400 From: Hugues FRUCHET To: Hans Verkuil , Maxime Coquelin , Alexandre TORGUE , Mauro Carvalho Chehab CC: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-media@vger.kernel.org" , Benjamin Gaignard , Yannick FERTRE Subject: Re: [PATCH v1 4/5] [media] stm32-dcmi: set default format at open() Thread-Topic: [PATCH v1 4/5] [media] stm32-dcmi: set default format at open() Thread-Index: AQHTDRk3JMA+xp/x2kWxpoDQV+uvE6KOknuA Date: Mon, 21 Aug 2017 10:20:25 +0000 Message-ID: <47cc9905-27d8-abec-2e28-f97a073249c9@st.com> References: <1501236302-18097-1-git-send-email-hugues.fruchet@st.com> <1501236302-18097-5-git-send-email-hugues.fruchet@st.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.47] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-21_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2994 Lines: 107 On 08/04/2017 02:00 PM, Hans Verkuil wrote: > On 28/07/17 12:05, Hugues Fruchet wrote: >> Ensure that we start with default pixel format and resolution >> when opening a new instance. > > Why? The format is persistent in V4L2 and (re)opening the video device > shouldn't change the format. > > Suppose you use v4l2-ctl to set up a format. E.g. v4l2-ctl -v width=320,height-240. > Now run v4l2-ctl -V to get the format and with this code it would suddenly be > back to the default! > > You set up the default format in the dcmi_graph_notify_complete, but after that > it is only changed if userspace explicitly requests it. > > Regards, > > Hans > Thanks Hans, I didn't catch this before, thanks for explanation. >> >> Signed-off-by: Hugues Fruchet >> --- >> drivers/media/platform/stm32/stm32-dcmi.c | 49 ++++++++++++++++++------------- >> 1 file changed, 28 insertions(+), 21 deletions(-) >> >> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c >> index 4733d1f..2be56b6 100644 >> --- a/drivers/media/platform/stm32/stm32-dcmi.c >> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >> @@ -890,6 +890,28 @@ static int dcmi_enum_frameintervals(struct file *file, void *fh, >> return 0; >> } >> >> +static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi) >> +{ >> + struct v4l2_format f = { >> + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE, >> + .fmt.pix = { >> + .width = CIF_WIDTH, >> + .height = CIF_HEIGHT, >> + .field = V4L2_FIELD_NONE, >> + .pixelformat = dcmi->sd_formats[0]->fourcc, >> + }, >> + }; >> + int ret; >> + >> + ret = dcmi_try_fmt(dcmi, &f, NULL); >> + if (ret) >> + return ret; >> + dcmi->sd_format = dcmi->sd_formats[0]; >> + dcmi->fmt = f; >> + >> + return 0; >> +} >> + >> static const struct of_device_id stm32_dcmi_of_match[] = { >> { .compatible = "st,stm32-dcmi"}, >> { /* end node */ }, >> @@ -916,7 +938,13 @@ static int dcmi_open(struct file *file) >> if (ret < 0 && ret != -ENOIOCTLCMD) >> goto fh_rel; >> >> + ret = dcmi_set_default_fmt(dcmi); >> + if (ret) >> + goto power_off; >> + >> ret = dcmi_set_fmt(dcmi, &dcmi->fmt); >> + >> +power_off: >> if (ret) >> v4l2_subdev_call(sd, core, s_power, 0); >> fh_rel: >> @@ -991,27 +1019,6 @@ static int dcmi_release(struct file *file) >> .read = vb2_fop_read, >> }; >> >> -static int dcmi_set_default_fmt(struct stm32_dcmi *dcmi) >> -{ >> - struct v4l2_format f = { >> - .type = V4L2_BUF_TYPE_VIDEO_CAPTURE, >> - .fmt.pix = { >> - .width = CIF_WIDTH, >> - .height = CIF_HEIGHT, >> - .field = V4L2_FIELD_NONE, >> - .pixelformat = dcmi->sd_formats[0]->fourcc, >> - }, >> - }; >> - int ret; >> - >> - ret = dcmi_try_fmt(dcmi, &f, NULL); >> - if (ret) >> - return ret; >> - dcmi->sd_format = dcmi->sd_formats[0]; >> - dcmi->fmt = f; >> - return 0; >> -} >> - >> static const struct dcmi_format dcmi_formats[] = { >> { >> .fourcc = V4L2_PIX_FMT_RGB565, >> >