Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbdHUKaZ (ORCPT ); Mon, 21 Aug 2017 06:30:25 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:35187 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbdHUKaX (ORCPT ); Mon, 21 Aug 2017 06:30:23 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: wdc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 3/4] clk: rockchip: rv1108: rename macphy to mac To: Elaine Zhang , mturquette@baylibre.com, sboyd@codeaurora.org, heiko@sntech.de Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com, cl@rock-chips.com, andy.yan@rock-chips.com, wdc@rock-chips.com References: <1503303367-17915-1-git-send-email-zhangqing@rock-chips.com> <1503303367-17915-4-git-send-email-zhangqing@rock-chips.com> From: "David.Wu" Message-ID: <521d67b9-3598-8781-c2a0-76e7829c9a45@rock-chips.com> Date: Mon, 21 Aug 2017 18:30:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503303367-17915-4-git-send-email-zhangqing@rock-chips.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 16 Hi Elaine, ?? 2017/8/21 16:16, Elaine Zhang ะด??: > This MAC has no internal phy for rv1108. > > Signed-off-by: Elaine Zhang > --- > drivers/clk/rockchip/clk-rv1108.c | 12 ++++++------ > include/dt-bindings/clock/rv1108-cru.h | 6 +++--- > 2 files changed, 9 insertions(+), 9 deletions(-) Acked-by: David Wu Usually, MAC and PHY are separate, macphy is easy to cause ambiguity, and RV1108 SOC does not have integrated ethernet PHY. It is more clear to change the name.