Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbdHUKbB (ORCPT ); Mon, 21 Aug 2017 06:31:01 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:35504 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbdHUKbA (ORCPT ); Mon, 21 Aug 2017 06:31:00 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: wdc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 4/4] clk: rockchip: rv1108: fix up the clk_mac sel register description To: Elaine Zhang , mturquette@baylibre.com, sboyd@codeaurora.org, heiko@sntech.de Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, xxx@rock-chips.com, xf@rock-chips.com, huangtao@rock-chips.com, cl@rock-chips.com, andy.yan@rock-chips.com, wdc@rock-chips.com References: <1503303367-17915-1-git-send-email-zhangqing@rock-chips.com> <1503303367-17915-5-git-send-email-zhangqing@rock-chips.com> From: "David.Wu" Message-ID: <2f6cae9a-b595-453f-1fd3-1858f7774cd9@rock-chips.com> Date: Mon, 21 Aug 2017 18:30:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503303367-17915-5-git-send-email-zhangqing@rock-chips.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 30 Hi Elaine, ?? 2017/8/21 16:16, Elaine Zhang ะด??: > cru_sel24_con[8] > rmii_extclk_sel > clock source select control register > 1'b0: from internal PLL > 1'b1: from external IO > > Signed-off-by: Elaine Zhang > --- > drivers/clk/rockchip/clk-rv1108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > index 658da17c9d99..4d87828df4f7 100644 > --- a/drivers/clk/rockchip/clk-rv1108.c > +++ b/drivers/clk/rockchip/clk-rv1108.c > @@ -140,7 +140,7 @@ enum rv1108_plls { > PNAME(mux_uart0_p) = { "uart0_src", "uart0_frac", "xin24m" }; > PNAME(mux_uart1_p) = { "uart1_src", "uart1_frac", "xin24m" }; > PNAME(mux_uart2_p) = { "uart2_src", "uart2_frac", "xin24m" }; > -PNAME(mux_sclk_mac_p) = { "ext_gmac", "sclk_mac_pre" }; > +PNAME(mux_sclk_mac_p) = { "sclk_mac_pre", "ext_gmac" }; > PNAME(mux_i2s0_pre_p) = { "i2s0_src", "i2s0_frac", "ext_i2s", "xin12m" }; > PNAME(mux_i2s_out_p) = { "i2s0_pre", "xin12m" }; > PNAME(mux_i2s1_p) = { "i2s1_src", "i2s1_frac", "dummy", "xin12m" }; > Acked-by: David Wu