Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbdHULgm (ORCPT ); Mon, 21 Aug 2017 07:36:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57000 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbdHULgk (ORCPT ); Mon, 21 Aug 2017 07:36:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8F8FCC0587F1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH] staging: vboxvideo: constify drm_fb_helper_funcs To: Arvind Yadav , gregkh@linuxfoundation.org, michael.thayer@oracle.com, daniel@ffwll.ch Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org References: <1ec6b9eca12e894181fd05876481c7eef7eff691.1503309844.git.arvind.yadav.cs@gmail.com> From: Hans de Goede Message-ID: <03acbf1c-1ea2-06c2-7ec2-854f77af0cb4@redhat.com> Date: Mon, 21 Aug 2017 13:36:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1ec6b9eca12e894181fd05876481c7eef7eff691.1503309844.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 21 Aug 2017 11:36:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 37 Hi, On 21-08-17 12:06, Arvind Yadav wrote: > drm_fb_helper_funcs are not supposed to change at runtime. > All functions working with drm_fb_helper_funcs provided by > work with const drm_fb_helper_funcs. > So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/staging/vboxvideo/vbox_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c > index 35f6d9f..70d99b7 100644 > --- a/drivers/staging/vboxvideo/vbox_fb.c > +++ b/drivers/staging/vboxvideo/vbox_fb.c > @@ -330,7 +330,7 @@ static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green, > *blue = regno; > } > > -static struct drm_fb_helper_funcs vbox_fb_helper_funcs = { > +static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = { > .gamma_set = vbox_fb_gamma_set, > .gamma_get = vbox_fb_gamma_get, > .fb_probe = vboxfb_create, >