Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbdHUMdT (ORCPT ); Mon, 21 Aug 2017 08:33:19 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:36005 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbdHUMdR (ORCPT ); Mon, 21 Aug 2017 08:33:17 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Ulf Hansson Date: Mon, 21 Aug 2017 14:33:16 +0200 Message-ID: Subject: Re: [PATCH] mmc: vub300: constify usb_device_id To: Arvind Yadav Cc: Tony Olech , "linux-mmc@vger.kernel.org" , Linux USB List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1107 Lines: 32 On 9 August 2017 at 19:50, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/vub300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c > index fbeea1a..6c99102 100644 > --- a/drivers/mmc/host/vub300.c > +++ b/drivers/mmc/host/vub300.c > @@ -266,7 +266,7 @@ MODULE_PARM_DESC(firmware_rom_wait_states, > #define ELAN_VENDOR_ID 0x2201 > #define VUB300_VENDOR_ID 0x0424 > #define VUB300_PRODUCT_ID 0x012C > -static struct usb_device_id vub300_table[] = { > +static const struct usb_device_id vub300_table[] = { > {USB_DEVICE(ELAN_VENDOR_ID, VUB300_PRODUCT_ID)}, > {USB_DEVICE(VUB300_VENDOR_ID, VUB300_PRODUCT_ID)}, > {} /* Terminating entry */ > -- > 2.7.4 >