Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753728AbdHUMik (ORCPT ); Mon, 21 Aug 2017 08:38:40 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33014 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753648AbdHUMig (ORCPT ); Mon, 21 Aug 2017 08:38:36 -0400 Date: Mon, 21 Aug 2017 15:38:32 +0300 From: Cihangir Akturk To: James Simmons Cc: "Dilger, Andreas" , Greg KH , Lustre Development List , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List , "Drokin, Oleg" Subject: Re: [PATCH] staging: lustre: fix structure size for ARM OABI Message-ID: <20170821123832.GC6148@yoga.localdomain> References: <1502894655-9731-1-git-send-email-cakturk@gmail.com> <20170817162639.GA13066@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 34 On Sun, Aug 20, 2017 at 03:52:26AM +0100, James Simmons wrote: > > > On Aug 17, 2017, at 10:26, Greg KH wrote: > > > > > > On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote: > > >> When building the kernel for the ARM architecture without setting > > >> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3 > > >> differs, due to different alignment requirements of OABI and EABI. > > I have to ask are you testing the lustre on ARM? No, I was just compiling the kernel for ARM architecture, and I hit this issue. If it's possible, I can give it a try with a bunch of raspberry pis or another cheap board? > > > >> Marking the anonymous union within struct lov_user_md_v3 as > > >> '_packed' solves this issue. Otherwise we get the following > > >> error: > > >> > > >> drivers/staging/lustre/lustre/lov/lov_pack.c:352:2: note: in expansion > > >> of macro ‘BUILD_BUG_ON’ > > >> BUILD_BUG_ON(sizeof(lum) != sizeof(struct lov_mds_md_v3)); > > >> > > >> Signed-off-by: Cihangir Akturk > > >> --- > > >> drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > This file is no longer in the tree :( > > > > With James' recent patch series, this has moved to include/uapi/linux/lustre/lustre_user.h > > BTW is __packed valid for UAPI headers?