Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbdHUNjK (ORCPT ); Mon, 21 Aug 2017 09:39:10 -0400 Received: from ozlabs.org ([103.22.144.67]:47325 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754061AbdHUNjI (ORCPT ); Mon, 21 Aug 2017 09:39:08 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 516fa8d0e19d854253460ea7692551e836e7e2b5 In-Reply-To: <7ce0e2734a7e95d3341c7424d124ddfd4bc82034.1497850925.git.arvind.yadav.cs@gmail.com> To: Arvind Yadav , benh@kernel.crashing.org, mingo@kernel.org From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [v2] macintosh: rack-meter: make of_device_ids const. Message-Id: <3xbZXq2CBfz9sR8@ozlabs.org> Date: Mon, 21 Aug 2017 23:39:07 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 20 On Mon, 2017-06-19 at 05:44:25 UTC, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 407 576 0 983 3d7 drivers/macintosh/rack-meter.o > > File size after constify rackmeter_match. > text data bss dec hex filename > 807 176 0 983 3d7 drivers/macintosh/rack-meter.o > > Signed-off-by: Arvind Yadav Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/516fa8d0e19d854253460ea7692551 cheers