Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbdHUOsl (ORCPT ); Mon, 21 Aug 2017 10:48:41 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35211 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126AbdHUOsi (ORCPT ); Mon, 21 Aug 2017 10:48:38 -0400 Date: Mon, 21 Aug 2017 07:48:33 -0700 From: Tejun Heo To: Laurent Vivier Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Jens Axboe , Lai Jiangshan , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/2] powerpc/workqueue: update list of possible CPUs Message-ID: <20170821144832.GE491396@devbig577.frc2.facebook.com> References: <20170821134951.18848-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170821134951.18848-1-lvivier@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 18 On Mon, Aug 21, 2017 at 03:49:50PM +0200, Laurent Vivier wrote: > In wq_numa_init() a list of NUMA nodes with their list of possible CPUs > is built. > > Unfortunately, on powerpc, the Firmware is only able to provide the > node of a CPU if the CPU is present. So, in our case (possible CPU) > CPU ids are known, but as the CPU is not present, the node id is > unknown and all the unplugged CPUs are attached to node 0. This is something powerpc needs to fix. Workqueue isn't the only one making this assumption. mm as a whole assumes that CPU <-> node mapping is stable regardless of hotplug events. Powerpc people know about the issue and AFAIK are working on it. Thanks. -- tejun