Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbdHUO7G convert rfc822-to-8bit (ORCPT ); Mon, 21 Aug 2017 10:59:06 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:33483 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753491AbdHUO7C (ORCPT ); Mon, 21 Aug 2017 10:59:02 -0400 From: Salil Mehta To: Leon Romanovsky CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware Thread-Topic: [PATCH V4 net-next] net: hns3: Add support to change MTU in HNS3 hardware Thread-Index: AQHTGotxf+FuYXzCxE+EB6Cj62sNfqKOwocAgAAin0A= Date: Mon, 21 Aug 2017 14:58:46 +0000 Message-ID: References: <20170821144003.49436-1-salil.mehta@huawei.com> <20170821144838.GO1724@mtr-leonro.local> In-Reply-To: <20170821144838.GO1724@mtr-leonro.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090201.599AF533.01A1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.205, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3297e909a9c710b73a022a8ccb422a44 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1814 Lines: 49 Hi Leon, > -----Original Message----- > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Monday, August 21, 2017 3:49 PM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next] net: hns3: Add support to change MTU > in HNS3 hardware > > On Mon, Aug 21, 2017 at 03:40:03PM +0100, Salil Mehta wrote: > > This patch adds the following support to the HNS3 driver: > > 1. Support to change the Maximum Transmission Unit of a > > port in the HNS NIC hardware. > > 2. Initializes the supported MTU range for the netdevice. > > > > Signed-off-by: lipeng > > Signed-off-by: Salil Mehta > > --- > > PATCH V4: Addressed some minor comments Leon Romanovsky > > 1. https://lkml.org/lkml/2017/8/21/212 > > PATCH V3: Addressed some minor comments Leon Romanovsky > > 1. https://lkml.org/lkml/2017/8/20/27 > > PATCH V2: Addresses comments given by Andrew Lunn > > 1. https://lkml.org/lkml/2017/8/18/282 > > PATCH V1: Initial Submit > > --- > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 34 > ++++++++++++++++++++++ > > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h | 1 + > > 2 files changed, 35 insertions(+) > > > > Wrong error code is not "minor" comment. Sorry for the wrong terminology used. Both of the comments were definitely useful and I have taken into consideration both of them in my recent patch. I think I missed it while replying, saw it while and created the patch later. Sorry for that again. I will correct this in my subsequent patch. Best regards Salil > > Thanks, > Reviewed-by: Leon Romanovsky