Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbdHUR6n (ORCPT ); Mon, 21 Aug 2017 13:58:43 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:37315 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753719AbdHUR6m (ORCPT ); Mon, 21 Aug 2017 13:58:42 -0400 Date: Mon, 21 Aug 2017 19:58:38 +0200 From: Krzysztof Kozlowski To: Maciej Purski Cc: linux-kernel@vger.kernel.org, cw00.choi@samsung.com, lee.jones@linaro.org, b.zolnierkie@samsung.com Subject: Re: [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell Message-ID: <20170821175838.g6cvtwqgvtw4n2es@kozik-lap> References: <1503312823-28462-1-git-send-email-m.purski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1503312823-28462-1-git-send-email-m.purski@samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 36 On Mon, Aug 21, 2017 at 12:53:43PM +0200, Maciej Purski wrote: > This patch adds muic of_compatible in order to use the muic device > driver in device tree. Please document it in similar way as in for example Documentation/devicetree/bindings/mfd/max14577.txt or in other way. Best regards, Krzysztof > > Signed-off-by: Maciej Purski > --- > drivers/mfd/max77693.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 662ae0d..1c05ea0 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = { > .name = "max77693-charger", > .of_compatible = "maxim,max77693-charger", > }, > - { .name = "max77693-muic", }, > + { > + .name = "max77693-muic", > + .of_compatible = "maxim,max77693-muic", > + }, > { > .name = "max77693-haptic", > .of_compatible = "maxim,max77693-haptic", > -- > 2.7.4 >