Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754096AbdHUSfb (ORCPT ); Mon, 21 Aug 2017 14:35:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56063 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbdHUSf2 (ORCPT ); Mon, 21 Aug 2017 14:35:28 -0400 Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: Document the POWER system power supply device To: Rob Herring Cc: linux@roeck-us.net, jdelvare@suse.com, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, joel@jms.id.au, jk@ozlabs.org, andrew@aj.id.au, mark.rutland@arm.com, devicetree@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org, "Edward A. James" References: <1502403586-20549-1-git-send-email-eajames@linux.vnet.ibm.com> <1502403586-20549-2-git-send-email-eajames@linux.vnet.ibm.com> <20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop> From: Eddie James Date: Mon, 21 Aug 2017 13:35:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170817151116.4vc4jlna4gc7xzb2@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17082118-2213-0000-0000-0000020CC36D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007586; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000223; SDB=6.00905647; UDB=6.00453842; IPR=6.00685850; BA=6.00005545; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016793; XFM=3.00000015; UTC=2017-08-21 18:35:24 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17082118-2214-0000-0000-0000574A9975 Message-Id: <81d68d38-af6d-be62-ad54-928b20b29d63@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-21_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708210289 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 52 On 08/17/2017 10:11 AM, Rob Herring wrote: > On Thu, Aug 10, 2017 at 05:19:44PM -0500, Eddie James wrote: >> From: "Edward A. James" >> >> Signed-off-by: Edward A. James >> --- >> .../devicetree/bindings/i2c/ibm,power-ps.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/i2c/ibm,power-ps.txt >> >> diff --git a/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt >> new file mode 100644 >> index 0000000..2ea8ea2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/ibm,power-ps.txt >> @@ -0,0 +1,21 @@ >> +Device-tree bindings for IBM POWER system power supplies >> +-------------------------------------------------------- >> + >> +Required properties: >> + - compatible = "ibm,power-ps"; >> + - reg = < I2C bus address >; : Address of the power supply on the >> + I2C bus. >> + >> +Example: >> + >> + i2c-bus@100 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #interrupt-cells = <1>; >> + < more properties > >> + >> + power_ps@68 { > Don't use '_' in node names. Should be a generic name too if possible. > Perhaps "power-supply". Yes, the latest patch set switched this to power-supply. The driver name changed in v3, sorry for the confusion. Thanks, Eddie > >> + compatible = "ibm,power-ps"; >> + reg = <0x68>; >> + }; >> + }; >> -- >> 1.8.3.1 >>