Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbdHUTUQ (ORCPT ); Mon, 21 Aug 2017 15:20:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:50412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541AbdHUTUO (ORCPT ); Mon, 21 Aug 2017 15:20:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E56E42170C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh@kernel.org MIME-Version: 1.0 In-Reply-To: <20170821133112.22276-3-danilokrummrich@dk-develop.de> References: <20170821133112.22276-1-danilokrummrich@dk-develop.de> <20170821133112.22276-3-danilokrummrich@dk-develop.de> From: Rob Herring Date: Mon, 21 Aug 2017 14:19:52 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 2/2] dt-bindings: new binding for ps/2 gpio devices To: Danilo Krummrich Cc: "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , Dmitry Torokhov , Linus Walleij , Randy Dunlap , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 54 On Mon, Aug 21, 2017 at 8:31 AM, Danilo Krummrich wrote: > The PS/2 gpio device binding defines the gpio pins (data and clock) > as well as the interrupt which should be used to drive the ps/2 bus. > It is expected to get an interrupt on the falling edge of the clock > line. > > Also it can be configured whether the host should support writing to > the device. > > Signed-off-by: Danilo Krummrich > --- > .../devicetree/bindings/serio/ps2-gpio.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt > > diff --git a/Documentation/devicetree/bindings/serio/ps2-gpio.txt b/Documentation/devicetree/bindings/serio/ps2-gpio.txt > new file mode 100644 > index 000000000000..83e05ea05883 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serio/ps2-gpio.txt > @@ -0,0 +1,22 @@ > +Device-Tree binding for ps/2 gpio device > + > +Required properties: > + - compatible = "ps2-gpio" > + - gpios: data and clock gpio Doesn't match the example. > + - interrupts: Should trigger on the falling edge of the clock line. > + > +Optional properties: > + - write-enable: Indicates whether write function is provided > + to serio device. Possibly providing the write fn will not work, because > + of the tough timing requirements. > + > +Example nodes: > + > +ps2@0 { > + compatible = "ps2-gpio"; > + interrupt-parent = <&gpio>; > + interrupts = <23 IRQ_TYPE_EDGE_FALLING>; > + data-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>; > + clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>; > + write-enable; > +}; > -- > 2.14.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html