Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbdHUTbt (ORCPT ); Mon, 21 Aug 2017 15:31:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39599 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbdHUTbo (ORCPT ); Mon, 21 Aug 2017 15:31:44 -0400 Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver To: Liang Yan , xen-devel@lists.xenproject.org, Juergen Gross , linux-kernel@vger.kernel.org, Dmitry Torokhov References: <599AFF3A02000047000184DE@prv-mh.provo.novell.com> <599AFF3A02000047000184DE@prv-mh.provo.novell.com> From: Boris Ostrovsky Message-ID: <2a2accd5-645c-7a68-f452-6ddbcccdb9cf@oracle.com> Date: Mon, 21 Aug 2017 15:30:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <599AFF3A02000047000184DE@prv-mh.provo.novell.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 32 Adding maintainer (Dmitry). -boris On 08/21/2017 11:41 AM, Liang Yan wrote: > Long pressed key could not show right in XEN vncviewer after tigervnc > client changed the way how to send repeat keys, from "Down Up Down Up > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard > device will trigger default auto repeat process from input subsystem, > and make auto repeat keys work correctly. > > Signed-off-by: Liang Yan > --- > drivers/input/misc/xen-kbdfront.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/misc/xen-kbdfront.c > b/drivers/input/misc/xen-kbdfront.c > index fa130e7b734c..0dce9830e2f4 100644 > --- a/drivers/input/misc/xen-kbdfront.c > +++ b/drivers/input/misc/xen-kbdfront.c > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev, > kbd->id.product = 0xffff; > > __set_bit(EV_KEY, kbd->evbit); > +__set_bit(EV_REP, kbd->evbit); > for (i = KEY_ESC; i < KEY_UNKNOWN; i++) > __set_bit(i, kbd->keybit); > for (i = KEY_OK; i < KEY_MAX; i++) > -- > 2.14.0 >