Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754434AbdHUU2H (ORCPT ); Mon, 21 Aug 2017 16:28:07 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:34453 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbdHUU2G (ORCPT ); Mon, 21 Aug 2017 16:28:06 -0400 MIME-Version: 1.0 In-Reply-To: <2a2accd5-645c-7a68-f452-6ddbcccdb9cf@oracle.com> References: <599AFF3A02000047000184DE@prv-mh.provo.novell.com> <2a2accd5-645c-7a68-f452-6ddbcccdb9cf@oracle.com> From: Dmitry Torokhov Date: Mon, 21 Aug 2017 13:28:05 -0700 Message-ID: Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver To: Boris Ostrovsky Cc: Liang Yan , xen-devel@lists.xenproject.org, Juergen Gross , lkml Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 46 On Mon, Aug 21, 2017 at 12:30 PM, Boris Ostrovsky wrote: > > Adding maintainer (Dmitry). I can't seem to find the original in my mailbox nor in patchwork. Can you please resend? > > > -boris > > On 08/21/2017 11:41 AM, Liang Yan wrote: > > Long pressed key could not show right in XEN vncviewer after tigervnc > > client changed the way how to send repeat keys, from "Down Up Down Up > > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard > > device will trigger default auto repeat process from input subsystem, > > and make auto repeat keys work correctly. > > > > Signed-off-by: Liang Yan > > --- > > drivers/input/misc/xen-kbdfront.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/misc/xen-kbdfront.c > > b/drivers/input/misc/xen-kbdfront.c > > index fa130e7b734c..0dce9830e2f4 100644 > > --- a/drivers/input/misc/xen-kbdfront.c > > +++ b/drivers/input/misc/xen-kbdfront.c > > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev, > > kbd->id.product = 0xffff; > > > > __set_bit(EV_KEY, kbd->evbit); > > +__set_bit(EV_REP, kbd->evbit); > > for (i = KEY_ESC; i < KEY_UNKNOWN; i++) > > __set_bit(i, kbd->keybit); > > for (i = KEY_OK; i < KEY_MAX; i++) > > -- > > 2.14.0 > > > Thanks. -- Dmitry