DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1F7CD60708
Subject: Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally
To: Kiran Gunda <kgunda@codeaurora.org>, gregkh@linuxfoundation.org,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
        David Collins <collinsd@codeaurora.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: shawnguo@kernel.org, linux-arm-msm@vger.kernel.org,
        linux-arm-msm-owner@vger.kernel.org
References: <1503070110-15018-1-git-send-email-kgunda@codeaurora.org>
From: Stephen Boyd <sboyd@codeaurora.org>
Message-ID: <e0af96c3-208b-abfc-8b2a-4ea1cc810ec7@codeaurora.org>
Date: Mon, 21 Aug 2017 16:18:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1503070110-15018-1-git-send-email-kgunda@codeaurora.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 736
Lines: 18

On 08/18/2017 08:28 AM, Kiran Gunda wrote:
> The peripheral ownership check is not necessary on single master
> platforms. Hence, enforce the peripheral ownership check optionally.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> Tested-by: Shawn Guo <shawnguo@kernel.org>
> ---

This sounds like a band-aid. Isn't the gpio driver going to keep probing
all the pins that are not supposed to be accessed due to security
constraints? What exactly is failing in the gpio case?

Also, I thought we were getting rid of the ownership checks? Or at
least, putting them behind some debug kernel feature check or something?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project