Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932102AbdHVApR (ORCPT ); Mon, 21 Aug 2017 20:45:17 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34569 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbdHVApP (ORCPT ); Mon, 21 Aug 2017 20:45:15 -0400 Subject: Re: [PATCH v2 1/2] net: stmmac: Delete dead code for MDIO registration To: Romain Perier , Giuseppe Cavallaro , Alexandre Torgue , Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170821114530.13706-1-romain.perier@collabora.com> <20170821114530.13706-2-romain.perier@collabora.com> From: Florian Fainelli Message-ID: <6ea649a3-4418-8025-44a9-72330f632f22@gmail.com> Date: Mon, 21 Aug 2017 17:45:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170821114530.13706-2-romain.perier@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 50 On 08/21/2017 04:45 AM, Romain Perier wrote: > This code is no longer used, the logging function was changed by commit > fbca164776e4 ("net: stmmac: Use the right logging functi"). > > Fixes: fbca164776e4 ("net: stmmac: Use the right logging functi") > Signed-off-by: Romain Perier > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index 72ec711fcba2..f5f37bfa1d58 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -248,9 +248,6 @@ int stmmac_mdio_register(struct net_device *ndev) > found = 0; > for (addr = 0; addr < PHY_MAX_ADDR; addr++) { > struct phy_device *phydev = mdiobus_get_phy(new_bus, addr); > - int act = 0; > - char irq_num[4]; > - char *irq_str; > > if (!phydev) > continue; > @@ -273,19 +270,6 @@ int stmmac_mdio_register(struct net_device *ndev) > if (priv->plat->phy_addr == -1) > priv->plat->phy_addr = addr; > > - act = (priv->plat->phy_addr == addr); > - switch (phydev->irq) { > - case PHY_POLL: > - irq_str = "POLL"; > - break; > - case PHY_IGNORE_INTERRUPT: > - irq_str = "IGNORE"; > - break; > - default: > - sprintf(irq_num, "%d", phydev->irq); > - irq_str = irq_num; > - break; > - } I was actually just looking into moving these prints to phy_attached_info(), since it is useful to know whether the interrupt is POLL, IGNORE, or valid. Can you move that there? Then you can really migrate over phy_attached_info() with no information loss. Thanks! -- Florian