Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932116AbdHVBVM (ORCPT ); Mon, 21 Aug 2017 21:21:12 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:57245 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbdHVBVL (ORCPT ); Mon, 21 Aug 2017 21:21:11 -0400 Subject: Re: [PATCH v2 2/3] i2c: davinci: Add PM Runtime Support To: Sekhar Nori , , , , , , , , , References: <20170816221715.15027-1-fcooper@ti.com> <20170816221715.15027-3-fcooper@ti.com> <8207a684-f010-ca82-baae-db06665f098e@ti.com> From: Franklin S Cooper Jr Message-ID: Date: Mon, 21 Aug 2017 20:17:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8207a684-f010-ca82-baae-db06665f098e@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.135] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 65 On 08/21/2017 04:05 AM, Sekhar Nori wrote: > On Thursday 17 August 2017 03:47 AM, Franklin S Cooper Jr wrote: > >> @@ -802,7 +821,6 @@ static int davinci_i2c_probe(struct platform_device *pdev) >> dev->clk = devm_clk_get(&pdev->dev, NULL); >> if (IS_ERR(dev->clk)) >> return PTR_ERR(dev->clk); >> - clk_prepare_enable(dev->clk); >> >> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> dev->base = devm_ioremap_resource(&pdev->dev, mem); >> @@ -811,6 +829,18 @@ static int davinci_i2c_probe(struct platform_device *pdev) >> goto err_unuse_clocks; > > This goto is wrong now. There is no need to unwind the pm_runtime setup > on a devm_ioremap_resource() failure. You can just return error here. Ok > >> } >> >> + pm_runtime_set_autosuspend_delay(dev->dev, >> + DAVINCI_I2C_PM_TIMEOUT); >> + pm_runtime_use_autosuspend(dev->dev); >> + >> + pm_runtime_enable(dev->dev); >> + >> + r = pm_runtime_get_sync(dev->dev); >> + if (r < 0) { >> + dev_err(dev->dev, "failed to runtime_get device: %d\n", r); >> + goto err_unuse_clocks; >> + } >> + >> i2c_davinci_init(dev); >> >> r = devm_request_irq(&pdev->dev, dev->irq, i2c_davinci_isr, 0, >> @@ -849,10 +879,16 @@ static int davinci_i2c_probe(struct platform_device *pdev) >> if (r) >> goto err_unuse_clocks; >> >> + pm_runtime_mark_last_busy(dev->dev); >> + pm_runtime_put_autosuspend(dev->dev); >> + >> return 0; >> >> err_unuse_clocks: >> - clk_disable_unprepare(dev->clk); >> + pm_runtime_dont_use_autosuspend(dev->dev); >> + pm_runtime_put_sync(dev->dev); >> + pm_runtime_disable(dev->dev); >> + >> dev->clk = NULL; > > This null setting of clk seems quite bogus and can be cleaned-up. Do you mean that I should just remove this line? > >> return r; >> } > > Thanks, > Sekhar >