Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754536AbdHVGQM (ORCPT ); Tue, 22 Aug 2017 02:16:12 -0400 Received: from mail-he1eur01on0082.outbound.protection.outlook.com ([104.47.0.82]:28635 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751317AbdHVGQL (ORCPT ); Tue, 22 Aug 2017 02:16:11 -0400 From: Noam Camus To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 07/11] ARC: [plat-eznps] new command line argument for HW scheduler at MTM Thread-Topic: [PATCH v3 07/11] ARC: [plat-eznps] new command line argument for HW scheduler at MTM Thread-Index: AQHS5bOxiXyLGpjyP0y0MDiGsznSE6KPc48AgADcn2A= Date: Tue, 22 Aug 2017 06:16:08 +0000 Message-ID: References: <1497516241-16446-1-git-send-email-noamca@mellanox.com> <1497516241-16446-8-git-send-email-noamca@mellanox.com> <390c39c5-9188-ad39-a61b-b959e79a469a@synopsys.com> In-Reply-To: <390c39c5-9188-ad39-a61b-b959e79a469a@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=noamca@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM5PR0502MB2993;6:g8ejWpceKj10Da3AAarXxQOcUzhY6AiigpGX21GecLoMTsvt4RAszvFS12t0og0sXxKSaNWIO95aH5miCy1tuiGt5add3D0TS9TQ/siIAF7E5Kfh1SKtZ4ne68Yw/Og0KSdvRENAQ2Q4pvJqdE3PnefpsyOX0vtgYlfPihnMyiCWwwtvAsGkvSQ6iau1yS54UNQr6Hb91SlxoGazJFW/o9dql1o/1Z9ED4ptT0CR6kq7El0/o3ar5QUL5u8aNPQI5yvOd+LaArEV6mRAVxiSf3obw0z7CXkti4x69cadWFuf9gh6G5Zlnkx4Q+rQenOddNwHD6ABuN/PFItvVwAo1A==;5:WamVTnynTXQVqJJYMr8HNCMu0v5QDkMLHzWTXo1lY6cdaUPHQqGatpcbV50PbjU9MThwdTmOlY4vbWP92GchMt6mw4zn09qAH1C4a9WsEaHHPuTc8i2Ryt80m7sBjNb3NFAzIPi+jUfoqjwtV6rGsQ==;24:5By4+HZagMTEmSjH2jLkK/n3pR5cdqP0Az43ExddZ85u22mRyY+T023EuIy07xIRuxmTaJ+ncqyDuq/Wb7fbEvIrei2BTeb2pWUuULVQF38=;7:d+MyP4loVw67qDp/i8iP002A4KsaFk242OG7jQ20XZTR7GXIo5/p0zgmI7T2jPdeQ7M5HAqn9o0DCyN8Pf9PEfdN1o3ohVrZKAj59y7lxuIlTuhmbTGe86KixZL4PLWUlska/WRgefXFdx1B9A37eFlRCruPwrdlG9gpjmAUMytLy2QEvGBs8cD+hpAcVRXwgtrvM2Vu5dmvCGmr9uuLO3paOPSIS5e8AQR+dT/IXtc= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 57768365-cc67-4344-d110-08d4e9254796 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM5PR0502MB2993; x-ms-traffictypediagnostic: AM5PR0502MB2993: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM5PR0502MB2993;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM5PR0502MB2993; x-forefront-prvs: 04073E895A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(189002)(377454003)(199003)(305945005)(68736007)(7736002)(81156014)(7696004)(66066001)(8676002)(8936002)(14454004)(229853002)(2900100001)(5660300001)(189998001)(5250100002)(2501003)(81166006)(97736004)(76176999)(53936002)(50986999)(54356999)(6246003)(74316002)(106356001)(55016002)(6436002)(99286003)(33656002)(4326008)(6506006)(105586002)(101416001)(2950100002)(478600001)(9686003)(86362001)(2906002)(102836003)(3660700001)(3280700002)(25786009)(3846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0502MB2993;H:AM5PR0502MB2996.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2017 06:16:08.9898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0502MB2993 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7M6GMJA028335 Content-Length: 626 Lines: 17 >From: Vineet Gupta [mailto:Vineet.Gupta1@synopsys.com] >Sent: Monday, August 21, 2017 20:04 PM .... >> + >> +/* Handle an out of bounds mtm hs counter value */ static void __init >> +handle_mtm_hs_ctr_out_of_bounds_error(uint8_t val) { >> + pr_err("** The value must be in range [%d,%d] (inclusive)\n", >> + MT_HS_CNT_MIN, MT_HS_CNT_MAX); >> + >> + mtm_hs_ctr = val; >This error handling doesn't make sense to me - if the value is not in range, why bother setting it at all. I'll fix it up locally. Just look what we provide handle_mtm_hs_ctr_out_of_bounds_error() as parameter and it will be sensible to you :) Noam