Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138AbdHVGfQ (ORCPT ); Tue, 22 Aug 2017 02:35:16 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38875 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbdHVGfN (ORCPT ); Tue, 22 Aug 2017 02:35:13 -0400 Date: Tue, 22 Aug 2017 08:35:07 +0200 From: Daniel Vetter To: Arvind Yadav Cc: airlied@linux.ie, kraxel@redhat.com, daniel.vetter@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] drm: virtio: constify drm_fb_helper_funcs Message-ID: <20170822063507.2rof6p66h57qezkv@phenom.ffwll.local> Mail-Followup-To: Arvind Yadav , airlied@linux.ie, kraxel@redhat.com, daniel.vetter@intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <60db0ba6ddce08444299533e97c9adec3b3ef1bb.1503311145.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60db0ba6ddce08444299533e97c9adec3b3ef1bb.1503311145.git.arvind.yadav.cs@gmail.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 41 On Mon, Aug 21, 2017 at 04:37:32PM +0530, Arvind Yadav wrote: > drm_fb_helper_funcs are not supposed to change at runtime. > All functions working with drm_fb_helper_funcs provided > by work with const drm_fb_helper_funcs. > So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c > index 33df067..61f33ec 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_fb.c > +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c > @@ -309,7 +309,7 @@ static int virtio_gpu_fbdev_destroy(struct drm_device *dev, > > return 0; > } > -static struct drm_fb_helper_funcs virtio_gpu_fb_helper_funcs = { > +static const struct drm_fb_helper_funcs virtio_gpu_fb_helper_funcs = { I have this patch already from someone else. Please create your patches against linux-next to avoid this kind of duplicated work. Thanks, Daniel > .fb_probe = virtio_gpufb_create, > }; > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch