Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754606AbdHVGmT (ORCPT ); Tue, 22 Aug 2017 02:42:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50571 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751384AbdHVGmP (ORCPT ); Tue, 22 Aug 2017 02:42:15 -0400 Subject: Re: [PATCH 0/2] Allow scsi_prep_fn to occur for retried commands From: Abdul Haleem To: Brian King Cc: Bart Van Assche , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "hch@lst.de" , "linux-scsi@vger.kernel.org" , "sfr@canb.auug.org.au" , "sachinp@linux.vnet.ibm.com" , "linux-next@vger.kernel.org" , "hare@suse.com" , "mpe@ellerman.id.au" Date: Tue, 22 Aug 2017 12:12:04 +0530 In-Reply-To: References: <1502902815.3305.22.camel@abdul.in.ibm.com> <1502904072.2421.3.camel@wdc.com> <2f686064-3e32-df8d-134f-962b5181da9d@linux.vnet.ibm.com> <1502985161.2615.8.camel@wdc.com> <71fb9c1b-9f3f-acdc-8bb5-aa1240aea763@linux.vnet.ibm.com> <1503092473.2622.17.camel@wdc.com> <0f7e2114-eba1-f149-ea80-d32d8b6d212a@linux.vnet.ibm.com> <1503094414.2622.21.camel@wdc.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17082206-0008-0000-0000-000001544462 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17082206-0009-0000-0000-000009872AA2 Message-Id: <1503384124.3629.22.camel@abdul.in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-22_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708220104 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 32 On Mon, 2017-08-21 at 17:11 -0500, Brian King wrote: > The following two patches address the hang issue being observed > with Bart's patch on powerpc. The first patch moves the initialization > of jiffies_at_alloc from scsi_init_command to scsi_init_rq, and ensures > we don't zero jiffies_at_alloc in scsi_init_command. The second patch > saves / restores the retry counter in scsi_init_command which lets us > go through scsi_init_command for retries and not forget why we were > there. > > These patches have only been boot tested on my Power machine with ipr > to ensure they fix the issue I was seeing. > > -Brian > Thank you Brian and Bart, for your efforts to fix this bug. I tested these patches on my PowerPC machine and system booted fine. [PATCHv2 1/2] scsi: Move scsi_cmd->jiffies_at_alloc initialization to allocation time [PATCH 2/2] scsi: Preserve retry counter through scsi_prep_fn Reported-and-Tested-by: Abdul Haleem -- Regard's Abdul Haleem IBM Linux Technology Centre