MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset="utf-8"
Message-id: <599BDA39.8030906@samsung.com>
Date: Tue, 22 Aug 2017 16:16:09 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: Maciej Purski <m.purski@samsung.com>, linux-kernel@vger.kernel.org
Cc: krzk@kernel.org, lee.jones@linaro.org, b.zolnierkie@samsung.com
Subject: Re: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
In-reply-to: <599BD9CF.1000604@samsung.com>
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20170822070923eucas1p2fb95310a7376a7a2869a970756d75631@eucas1p2.samsung.com>
        <1503385752-5661-1-git-send-email-m.purski@samsung.com>
        <599BD9CF.1000604@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1932
Lines: 64

On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
> 
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documentation
>>
>> Signed-off-by: Maciej Purski <m.purski@samsung.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>>  drivers/mfd/max77693.c                             | 5 ++++-
>>  2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
>> index 6a1ae3a..6ca2478 100644
>> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
>> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
>> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>>  Optional properties for the LED child node:
>>  - label : see Documentation/devicetree/bindings/leds/common.txt
>>  
>> +Optional nodes:
>> +- max77693-muic/max77693-muic :

Also, max77693-muic is duplicate.

>> +	Node used only by extcon consumers.
>> +	Required properties:
>> +		- compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
> 
> "maxim,max77693-muic" is duplicate. Please add just one compatible.
> 
>> +
>>  Example:
>>  #include <dt-bindings/leds/common.h>
>>  
>> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
>> index 662ae0d..1c05ea0 100644
>> --- a/drivers/mfd/max77693.c
>> +++ b/drivers/mfd/max77693.c
>> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>>  		.name = "max77693-charger",
>>  		.of_compatible = "maxim,max77693-charger",
>>  	},
>> -	{ .name = "max77693-muic", },
>> +	{
>> +		.name = "max77693-muic",
>> +		.of_compatible = "maxim,max77693-muic",
>> +	},
>>  	{
>>  		.name = "max77693-haptic",
>>  		.of_compatible = "maxim,max77693-haptic",
>>
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics