Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754702AbdHVHZ2 (ORCPT ); Tue, 22 Aug 2017 03:25:28 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:48267 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754604AbdHVHZ0 (ORCPT ); Tue, 22 Aug 2017 03:25:26 -0400 Message-ID: <1503386722.23987.5.camel@mtkswgap22> Subject: Re: [PATCH] crypto: mediatek - Add empty messages check in GCM mode From: Ryder Lee To: Herbert Xu CC: , , Date: Tue, 22 Aug 2017 15:25:22 +0800 In-Reply-To: <20170822070144.GA5989@gondor.apana.org.au> References: <018d5b804a22b0aa2e4d759749884b0e15c25de4.1502861307.git.ryder.lee@mediatek.com> <20170822070144.GA5989@gondor.apana.org.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 33 Hi, On Tue, 2017-08-22 at 15:01 +0800, Herbert Xu wrote: > On Wed, Aug 16, 2017 at 07:19:48PM +0800, Ryder Lee wrote: > > Currently, empty messages are not supported in GCM mode, hence add > > a check to prevent producing incorrect results. > > > > Signed-off-by: Ryder Lee > > --- > > drivers/crypto/mediatek/mtk-aes.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/crypto/mediatek/mtk-aes.c b/drivers/crypto/mediatek/mtk-aes.c > > index 9e845e8..efe4e63 100644 > > --- a/drivers/crypto/mediatek/mtk-aes.c > > +++ b/drivers/crypto/mediatek/mtk-aes.c > > @@ -928,8 +928,13 @@ static int mtk_aes_gcm_start(struct mtk_cryp *cryp, struct mtk_aes_rec *aes) > > static int mtk_aes_gcm_crypt(struct aead_request *req, u64 mode) > > { > > struct mtk_aes_base_ctx *ctx = crypto_aead_ctx(crypto_aead_reqtfm(req)); > > + struct mtk_aes_gcm_ctx *gctx = mtk_aes_gcm_ctx_cast(ctx); > > struct mtk_aes_reqctx *rctx = aead_request_ctx(req); > > > > + /* Empty messages are not supported yet */ > > + if (!gctx->textlen && !req->assoclen) > > + return -EINVAL > > Your patch does not compile. Ohh..Somehow I delete the semicolon. I will send v1 soon, sorry about that. Ryder