Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754700AbdHVHpx (ORCPT ); Tue, 22 Aug 2017 03:45:53 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:36184 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754645AbdHVHpw (ORCPT ); Tue, 22 Aug 2017 03:45:52 -0400 X-IronPort-AV: E=Sophos;i="5.41,411,1498546800"; d="scan'208";a="4048662" Subject: Re: [PATCH 3/3] media: atmel-isc: Add more format configurations To: Hans Verkuil , Mauro Carvalho Chehab CC: Nicolas Ferre , , Sakari Ailus , Jonathan Corbet , , Linux Media Mailing List References: <20170817071614.12767-1-wenyou.yang@microchip.com> <20170817071614.12767-4-wenyou.yang@microchip.com> <3b7a0d2a-f8e7-93d1-6cfc-78bfe5e4dbba@xs4all.nl> From: "Yang, Wenyou" Message-ID: <0ed547e4-4507-565d-f172-f11f39fb7ab0@Microchip.com> Date: Tue, 22 Aug 2017 15:45:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <3b7a0d2a-f8e7-93d1-6cfc-78bfe5e4dbba@xs4all.nl> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2797 Lines: 71 Hi Hans, On 2017/8/22 14:54, Hans Verkuil wrote: > On 08/17/2017 09:16 AM, Wenyou Yang wrote: >> Add the configuration of formats: GREY, ARGB444, ARGB555 and ARGB32. >> >> Signed-off-by: Wenyou Yang >> --- >> >> drivers/media/platform/atmel/atmel-isc.c | 22 ++++++++++++++++++++-- >> 1 file changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c >> index d91f4e5f8a8d..4e18fe1104c8 100644 >> --- a/drivers/media/platform/atmel/atmel-isc.c >> +++ b/drivers/media/platform/atmel/atmel-isc.c >> @@ -184,7 +184,7 @@ struct isc_device { >> #define RAW_FMT_IND_START 0 >> #define RAW_FMT_IND_END 11 >> #define ISC_FMT_IND_START 12 >> -#define ISC_FMT_IND_END 14 >> +#define ISC_FMT_IND_END 18 > Shouldn't this be 19? From ISC_FMT_IND_START to ISC_FMT_IND_END, it describes the formats they can be got from both the sensor (possibly) and the ISC controller. The last format (19) is in not this category. It maybe be got from the sensor, can't be generated by the controller. > Regards, > > Hans > >> >> static struct isc_format isc_formats[] = { >> /* 0 */ >> @@ -246,12 +246,30 @@ static struct isc_format isc_formats[] = { >> { V4L2_PIX_FMT_YUV422P, 0x0, 16, >> ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_YYCC, >> ISC_DCFG_IMODE_YC422P, ISC_DCTRL_DVIEW_PLANAR, 0x3fb }, >> + >> /* 14 */ >> + { V4L2_PIX_FMT_GREY, MEDIA_BUS_FMT_Y8_1X8, 8, >> + ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_DATY8, >> + ISC_DCFG_IMODE_PACKED8, ISC_DCTRL_DVIEW_PACKED, 0x1fb }, >> + >> + /* 15 */ >> + { V4L2_PIX_FMT_ARGB444, MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE, 16, >> + ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_ARGB444, >> + ISC_DCFG_IMODE_PACKED16, ISC_DCTRL_DVIEW_PACKED, 0x7b }, >> + /* 16 */ >> + { V4L2_PIX_FMT_ARGB555, MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE, 16, >> + ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_ARGB555, >> + ISC_DCFG_IMODE_PACKED16, ISC_DCTRL_DVIEW_PACKED, 0x7b }, >> + /* 17 */ >> { V4L2_PIX_FMT_RGB565, MEDIA_BUS_FMT_RGB565_2X8_LE, 16, >> ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_RGB565, >> ISC_DCFG_IMODE_PACKED16, ISC_DCTRL_DVIEW_PACKED, 0x7b }, >> + /* 18 */ >> + { V4L2_PIX_FMT_ARGB32, MEDIA_BUS_FMT_ARGB8888_1X32, 32, >> + ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_ARGB32, >> + ISC_DCFG_IMODE_PACKED32, ISC_DCTRL_DVIEW_PACKED, 0x7b }, >> >> - /* 15 */ >> + /* 19 */ >> { V4L2_PIX_FMT_YUYV, MEDIA_BUS_FMT_YUYV8_2X8, 16, >> ISC_PFE_CFG0_BPS_EIGHT, ISC_BAY_CFG_BGBG, ISC_RLP_CFG_MODE_DAT8, >> ISC_DCFG_IMODE_PACKED8, ISC_DCTRL_DVIEW_PACKED, 0x0 }, >> Best Regards, Wenyou Yang