Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932250AbdHVH6e (ORCPT ); Tue, 22 Aug 2017 03:58:34 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:40874 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932170AbdHVH6a (ORCPT ); Tue, 22 Aug 2017 03:58:30 -0400 Date: Tue, 22 Aug 2017 15:58:18 +0800 From: Herbert Xu To: Corentin Labbe Cc: george.cherian@cavium.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: cavium - add release_firmware to all return case Message-ID: <20170822075818.GF6269@gondor.apana.org.au> References: <20170814115854.19495-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170814115854.19495-1-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 552 Lines: 16 On Mon, Aug 14, 2017 at 01:58:54PM +0200, Corentin Labbe wrote: > Two return case misses to call release_firmware() and so leak some > memory. > > This patch create a fw_release label (and so a common error path) > and use it on all return case. > > Detected by CoverityScan, CID#1416422 ("Resource Leak") > > Signed-off-by: Corentin Labbe Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt