Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932306AbdHVIlw (ORCPT ); Tue, 22 Aug 2017 04:41:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932132AbdHVIls (ORCPT ); Tue, 22 Aug 2017 04:41:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3AD437E42C Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mcroce@redhat.com Message-ID: <1503391305.2409.12.camel@redhat.com> Subject: Re: [PATCH] drivers: net: wireless: atmel: check memory allocation failure From: Matteo Croce To: Himanshu Jha , kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Tue, 22 Aug 2017 10:41:45 +0200 In-Reply-To: <1503389481-4988-1-git-send-email-himanshujha199640@gmail.com> References: <1503389481-4988-1-git-send-email-himanshujha199640@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 22 Aug 2017 08:41:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2673 Lines: 98 Il giorno mar, 22/08/2017 alle 13.41 +0530, Himanshu Jha ha scritto: > Check memory allocation failure and return -ENOMEM if failure > occurs. > > Signed-off-by: Himanshu Jha > --- > drivers/net/wireless/atmel/at76c50x-usb.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c > b/drivers/net/wireless/atmel/at76c50x-usb.c > index 09defbc..73f0924 100644 > --- a/drivers/net/wireless/atmel/at76c50x-usb.c > +++ b/drivers/net/wireless/atmel/at76c50x-usb.c > @@ -940,7 +940,7 @@ static void at76_dump_mib_mac_addr(struct > at76_priv *priv) > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_MAC_ADDR, m, > sizeof(struct mib_mac_addr)); > @@ -969,7 +969,7 @@ static void at76_dump_mib_mac_wep(struct > at76_priv *priv) > struct mib_mac_wep *m = kmalloc(sizeof(struct mib_mac_wep), > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_MAC_WEP, m, > sizeof(struct mib_mac_wep)); > @@ -1006,7 +1006,7 @@ static void at76_dump_mib_mac_mgmt(struct > at76_priv *priv) > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_MAC_MGMT, m, > sizeof(struct mib_mac_mgmt)); > @@ -1043,7 +1043,7 @@ static void at76_dump_mib_mac(struct at76_priv > *priv) > struct mib_mac *m = kmalloc(sizeof(struct mib_mac), > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_MAC, m, sizeof(struct > mib_mac)); > if (ret < 0) { > @@ -1080,7 +1080,7 @@ static void at76_dump_mib_phy(struct at76_priv > *priv) > struct mib_phy *m = kmalloc(sizeof(struct mib_phy), > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_PHY, m, sizeof(struct > mib_phy)); > if (ret < 0) { > @@ -1113,7 +1113,7 @@ static void at76_dump_mib_local(struct > at76_priv *priv) > struct mib_local *m = kmalloc(sizeof(*m), GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(*m)); > if (ret < 0) { > @@ -1138,7 +1138,7 @@ static void at76_dump_mib_mdomain(struct > at76_priv *priv) > struct mib_mdomain *m = kmalloc(sizeof(struct mib_mdomain), > GFP_KERNEL); > > if (!m) > - return; > + return -ENOMEM; > > ret = at76_get_mib(priv->udev, MIB_MDOMAIN, m, > sizeof(struct mib_mdomain)); Perhaps these functions should return something instead of being void. Regards, -- Matteo Croce per aspera ad upstream