Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932374AbdHVJMB (ORCPT ); Tue, 22 Aug 2017 05:12:01 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:33864 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbdHVJL6 (ORCPT ); Tue, 22 Aug 2017 05:11:58 -0400 MIME-Version: 1.0 In-Reply-To: <1503086826.3688.30.camel@decadent.org.uk> References: <20170815011942.395714306@linuxfoundation.org> <20170815011944.581180081@linuxfoundation.org> <1503086826.3688.30.camel@decadent.org.uk> From: Chen-Yu Tsai Date: Tue, 22 Aug 2017 17:11:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4.12 55/65] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver To: Ben Hutchings Cc: Greg Kroah-Hartman , linux-kernel , stable@vger.kernel.org, Icenowy Zheng , Chen-Yu Tsai , Linus Walleij Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2232 Lines: 60 On Sat, Aug 19, 2017 at 4:07 AM, Ben Hutchings wrote: > On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote: >> 4.12-stable review patch. If anyone has any objections, please let me know. >> >> ------------------ >> >> From: Icenowy Zheng >> >> commit d81ece747d8727bb8b1cfc9a20dbe62f09a4e35a upstream. >> >> The PH16 pin has a function with mux id 0x5, which is the DET pin of the >> "sim" (smart card reader) IP block. >> >> This function is missing in old versions of A10/A20 SoCs' datasheets and >> user manuals, so it's also missing in the old drivers. The newest A10 >> Datasheet V1.70 and A20 Datasheet V1.41 contain this pin function, and >> it's discovered during implementing R40 pinctrl driver. >> >> Add it to the driver. As we now merged A20 pinctrl driver to the A10 >> one, we need to only fix the A10 driver now. > > That happened after 4.12, so I think for stable the same change should > be applied in drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c. Indeed. Should we send a backported patch? Thanks ChenYu > > Ben. > >> Fixes: f2821b1ca3a2 ("pinctrl: sunxi: Move Allwinner A10 pinctrl >> driver to a driver of its own") >> >> Signed-off-by: Icenowy Zheng >> Reviewed-by: Chen-Yu Tsai >> Signed-off-by: Linus Walleij >> Signed-off-by: Greg Kroah-Hartman >> >> --- >> drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c | 1 + >> 1 file changed, 1 insertion(+) >> >> --- a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c >> +++ b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c >> @@ -811,6 +811,7 @@ static const struct sunxi_desc_pin sun4i >> SUNXI_FUNCTION(0x2, "lcd1"), /* D16 */ >> SUNXI_FUNCTION(0x3, "pata"), /* ATAD12 */ >> SUNXI_FUNCTION(0x4, "keypad"), /* IN6 */ >> + SUNXI_FUNCTION(0x5, "sim"), /* DET */ >> SUNXI_FUNCTION_IRQ(0x6, 16), /* EINT16 */ >> SUNXI_FUNCTION(0x7, "csi1")), /* D16 */ >> SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 17), >> >> > -- > Ben Hutchings > Reality is just a crutch for people who can't handle science fiction. >