Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932425AbdHVJ0l (ORCPT ); Tue, 22 Aug 2017 05:26:41 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:40269 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbdHVJ0k (ORCPT ); Tue, 22 Aug 2017 05:26:40 -0400 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: dolinux.peng@gmail.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <0359d1386758e9647f0a6c1bac7fcb1c> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <599BF871.8000408@rock-chips.com> Date: Tue, 22 Aug 2017 17:25:05 +0800 From: jeffy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Donglin Peng CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, =?UTF-8?B?SGVpa28g?= =?UTF-8?B?U3TDvGJuZXI=?= , briannorris@chromium.org, mengdong.lin@linux.intel.com, mka@chromium.org, lars@metafoo.de, dianders@chromium.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org, Mark Brown , Takashi Iwai , Liam Girdwood , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-7-jeffy.chen@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 290 Lines: 10 Hi Donglin, On 08/22/2017 05:08 PM, Donglin Peng wrote: >> > card->dev = &pdev->dev; >> > platform_set_drvdata(pdev, card); > There is no need to call platform_set_drvdata, because > devm_snd_soc_register_card will do it. > right, will remove it in next version, thanks:)