Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932445AbdHVJ1N (ORCPT ); Tue, 22 Aug 2017 05:27:13 -0400 Received: from mail-qt0-f177.google.com ([209.85.216.177]:37810 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932368AbdHVJ1L (ORCPT ); Tue, 22 Aug 2017 05:27:11 -0400 MIME-Version: 1.0 In-Reply-To: <1502970766-23541-1-git-send-email-talho@nvidia.com> References: <1502970766-23541-1-git-send-email-talho@nvidia.com> From: Ulf Hansson Date: Tue, 22 Aug 2017 11:27:09 +0200 Message-ID: Subject: Re: [PATCH] mmc: tegra: suppress errors when probe is deferred To: Timo Alho Cc: Thierry Reding , Adrian Hunter , "linux-mmc@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 39 On 17 August 2017 at 13:52, Timo Alho wrote: > Don't print error message when clk_get() returns -EPROBE_DEFER. On > recent Tegra chips (t186 onwards), the clocks are provided by > auxiliary microprocessor (bpmp) and until the driver for it is probed > clocks are not available. > > While at it, change the real error message more meaningful. > > Signed-off-by: Timo Alho > --- > drivers/mmc/host/sdhci-tegra.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index f668a6f..cdde9ff 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -501,8 +501,10 @@ static int sdhci_tegra_probe(struct platform_device *pdev) > > clk = devm_clk_get(mmc_dev(host->mmc), NULL); > if (IS_ERR(clk)) { > - dev_err(mmc_dev(host->mmc), "clk err\n"); > rc = PTR_ERR(clk); > + if (rc != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "failed to get controller clock: %d\n", rc); There is no need to print an error in any case, as the common clk framework deals with relevant error printing. > goto err_clk_get; > } > clk_prepare_enable(clk); > -- > 2.7.4 > Kind regards Uffe