Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbdHVJ3k (ORCPT ); Tue, 22 Aug 2017 05:29:40 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35294 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932205AbdHVJ3i (ORCPT ); Tue, 22 Aug 2017 05:29:38 -0400 Date: Tue, 22 Aug 2017 14:59:31 +0530 From: Himanshu Jha To: Matteo Croce Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kvalo@codeaurora.org Subject: Re: [PATCH] drivers: net: wireless: atmel: check memory allocation failure Message-ID: <20170822092931.GA8490@himanshu-Vostro-3559> References: <1503389481-4988-1-git-send-email-himanshujha199640@gmail.com> <1503391305.2409.12.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503391305.2409.12.camel@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3083 Lines: 105 On Tue, Aug 22, 2017 at 10:41:45AM +0200, Matteo Croce wrote: > Il giorno mar, 22/08/2017 alle 13.41 +0530, Himanshu Jha ha scritto: > > Check memory allocation failure and return -ENOMEM if failure > > occurs. > > > > Signed-off-by: Himanshu Jha > > --- > > drivers/net/wireless/atmel/at76c50x-usb.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c > > b/drivers/net/wireless/atmel/at76c50x-usb.c > > index 09defbc..73f0924 100644 > > --- a/drivers/net/wireless/atmel/at76c50x-usb.c > > +++ b/drivers/net/wireless/atmel/at76c50x-usb.c > > @@ -940,7 +940,7 @@ static void at76_dump_mib_mac_addr(struct > > at76_priv *priv) > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_MAC_ADDR, m, > > sizeof(struct mib_mac_addr)); > > @@ -969,7 +969,7 @@ static void at76_dump_mib_mac_wep(struct > > at76_priv *priv) > > struct mib_mac_wep *m = kmalloc(sizeof(struct mib_mac_wep), > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_MAC_WEP, m, > > sizeof(struct mib_mac_wep)); > > @@ -1006,7 +1006,7 @@ static void at76_dump_mib_mac_mgmt(struct > > at76_priv *priv) > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_MAC_MGMT, m, > > sizeof(struct mib_mac_mgmt)); > > @@ -1043,7 +1043,7 @@ static void at76_dump_mib_mac(struct at76_priv > > *priv) > > struct mib_mac *m = kmalloc(sizeof(struct mib_mac), > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_MAC, m, sizeof(struct > > mib_mac)); > > if (ret < 0) { > > @@ -1080,7 +1080,7 @@ static void at76_dump_mib_phy(struct at76_priv > > *priv) > > struct mib_phy *m = kmalloc(sizeof(struct mib_phy), > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_PHY, m, sizeof(struct > > mib_phy)); > > if (ret < 0) { > > @@ -1113,7 +1113,7 @@ static void at76_dump_mib_local(struct > > at76_priv *priv) > > struct mib_local *m = kmalloc(sizeof(*m), GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(*m)); > > if (ret < 0) { > > @@ -1138,7 +1138,7 @@ static void at76_dump_mib_mdomain(struct > > at76_priv *priv) > > struct mib_mdomain *m = kmalloc(sizeof(struct mib_mdomain), > > GFP_KERNEL); > > > > if (!m) > > - return; > > + return -ENOMEM; > > > > ret = at76_get_mib(priv->udev, MIB_MDOMAIN, m, > > sizeof(struct mib_mdomain)); > > Perhaps these functions should return something instead of being void. > > Regards, > > -- > Matteo Croce > per aspera ad upstream Yes, it should return int to signal memory allocation failures and therefore function prototype should be static int rather than static void. Thanks!