Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbdHVJn1 (ORCPT ); Tue, 22 Aug 2017 05:43:27 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34912 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbdHVJn0 (ORCPT ); Tue, 22 Aug 2017 05:43:26 -0400 Subject: Re: [PATCH 0/3] constify drm i2c_device_id To: airlied@linux.ie, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1503167300-17334-1-git-send-email-arvind.yadav.cs@gmail.com> <20170822062900.vaclssbmt3tiemfl@phenom.ffwll.local> From: Arvind Yadav Message-ID: Date: Tue, 22 Aug 2017 15:13:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170822062900.vaclssbmt3tiemfl@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 40 Hi Daniel, On Tuesday 22 August 2017 12:01 PM, Daniel Vetter wrote: > On Sat, Aug 19, 2017 at 11:58:17PM +0530, Arvind Yadav wrote: >> i2c_device_id are not supposed to change at runtime. All functions >> working with i2c_device_id provided by work with >> const i2c_device_id. So mark the non-const structs as const. > All applied. > > btw I think this isn't your first series, and we're trying to keep some of > the trivial mistakes around in drm, as an easy way for newbies to get into > the subsystem with their first patch. > > We'd like more regular contributors to tackle some of the more involved > cleanup tasks, which should also be more valuable to the subsystem: > > file:///home/daniel/linux/src/Documentation/output/gpu/todo.html#todo I want to contribute drm and others subsystem. If you can guide me. It will helpful for me. > Cheers, Daniel > >> Arvind Yadav (3): >> [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id >> [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id >> [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id >> >> drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- >> drivers/gpu/drm/i2c/sil164_drv.c | 2 +- >> drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> -- >> 2.7.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel ~arvind