Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932563AbdHVK6L (ORCPT ); Tue, 22 Aug 2017 06:58:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:54994 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932429AbdHVK6K (ORCPT ); Tue, 22 Aug 2017 06:58:10 -0400 Date: Tue, 22 Aug 2017 12:58:07 +0200 Message-ID: From: Takashi Iwai To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Lee Jones , Dmitry Torokhov , "Rafael J . Wysocki" , Mika Westerberg , Johannes Stezenbach , linux-input@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button In-Reply-To: <1503394928.25945.46.camel@linux.intel.com> References: <20170822055710.26515-1-tiwai@suse.de> <20170822055710.26515-3-tiwai@suse.de> <1503394928.25945.46.camel@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 32 On Tue, 22 Aug 2017 11:42:08 +0200, Andy Shevchenko wrote: > > On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote: > > This provides a new input driver for supporting the power button on > > Dollar Cove TI PMIC, found on Cherrytrail-based devices. > > The patch is based on the original work by Intel, found at: > >   https://github.com/01org/ProductionKernelQuilts > > For now we have similar driver under drivers/platform/x86. > > I think when we move to regmap API there we might even reuse > intel_mid_powerbtn.c. Ah, OK, that can be a better place. I'll move to there. Also, from comparison with intel_mid_powerbtn.c, I noticed that the irq wake isn't cleared at removal. Will address it as well. > Or other way around, move that one to input subsystem (which I > personally see less fit). I don't think it's worth, either. I updated the patches and now pushed to topic/dollar-cove-ti-4.13-v2 branch. Will resubmit v2 (tomorrow or later) once after gathering reviews. thanks, Takashi