Message-ID: <599C0F20.7080807@rock-chips.com>
Date: Tue, 22 Aug 2017 19:01:52 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de,
        briannorris@chromium.org, mengdong.lin@linux.intel.com,
        mka@chromium.org, lars@metafoo.de, dianders@chromium.org,
        Jaroslav Kysela <perex@perex.cz>, devicetree@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-rockchip@lists.infradead.org,
        Liam Girdwood <lgirdwood@gmail.com>, Takashi Iwai <tiwai@suse.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        Oder Chiou <oder_chiou@realtek.com>
Subject: Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay
References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-2-jeffy.chen@rock-chips.com> <20170822103241.wjiycavsro7abknj@sirena.org.uk>
In-Reply-To: <20170822103241.wjiycavsro7abknj@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 704
Lines: 23

Hi Mark,

On 08/22/2017 06:32 PM, Mark Brown wrote:
> On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote:
>> This property is no longer used.
>
> I would still rather keep the existing property documented (the binding
> does need to be fixed) than remove it.  It's better practice and it's
> not costing a huge amount.
>

sorry, i should explain more in the commit msg...

just to clarify, this property is replaced by 
"realtek,dmic-init-delay-ms" in rt5514 driver:

a5461fd6c8f7 ASoC: rt5514: Add the DMIC initial delay to wait it ready.

which does exactly the same thing as the old one: perform a delay after 
set clk...

i can do that if you still insist to keep it, since it's harmless :)