Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbdHVLDI (ORCPT ); Tue, 22 Aug 2017 07:03:08 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59712 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932427AbdHVLDH (ORCPT ); Tue, 22 Aug 2017 07:03:07 -0400 Date: Tue, 22 Aug 2017 13:03:00 +0200 From: Peter Zijlstra To: Brendan Jackman Cc: Joel Fernandes , LKML , Andres Oportus , Ingo Molnar , Morten Rasmussen , Dietmar Eggemann , Vincent Guittot Subject: Re: [PATCH 2/2] sched/fair: Fix use of NULL with find_idlest_group Message-ID: <20170822110300.lcpzyzgzqshdv7df@hirez.programming.kicks-ass.net> References: <20170821152128.14418-1-brendan.jackman@arm.com> <20170821152128.14418-3-brendan.jackman@arm.com> <20170821211400.GF32112@worktop.programming.kicks-ass.net> <87efs33mzl.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87efs33mzl.fsf@arm.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 11 On Tue, Aug 22, 2017 at 11:39:26AM +0100, Brendan Jackman wrote: > However the code movement helps - I'll combine it with Vincent's > suggestions and post a v2. Please also split into multiple patches, as I feel this 2/2 does too many things. Fixing that this_*_load initialization stuff for instance could be a separate patch. And unlike what I did, do the whole code movement as a pure code movement, without any additional changes.