Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932706AbdHVMBW (ORCPT ); Tue, 22 Aug 2017 08:01:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:41206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932546AbdHVMBU (ORCPT ); Tue, 22 Aug 2017 08:01:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DDEF218FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=krzk@kernel.org MIME-Version: 1.0 In-Reply-To: <1503387537-18342-1-git-send-email-m.purski@samsung.com> References: <1503387537-18342-1-git-send-email-m.purski@samsung.com> From: Krzysztof Kozlowski Date: Tue, 22 Aug 2017 14:01:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell To: Maciej Purski Cc: linux-kernel@vger.kernel.org, Chanwoo Choi , lee.jones@linaro.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2069 Lines: 63 On Tue, Aug 22, 2017 at 9:38 AM, Maciej Purski wrote: > This patch adds muic of_compatible in order to use the muic device > driver in device tree. > > v2: > - added muic to documentation Change log should not go to commit message. Put it after separator ---. +cc devicetree - scripts/get_maintainer.pl should point you that list. With the change in commit msg: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > v3: > - removed duplication > > Signed-off-by: Maciej Purski > --- > Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++ > drivers/mfd/max77693.c | 5 ++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt > index 6a1ae3a..e675497 100644 > --- a/Documentation/devicetree/bindings/mfd/max77693.txt > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt > @@ -127,6 +127,12 @@ Required properties for the LED child node: > Optional properties for the LED child node: > - label : see Documentation/devicetree/bindings/leds/common.txt > > +Optional nodes: > +- max77693-muic : > + Node used only by extcon consumers. > + Required properties: > + - compatible : "maxim,max77693-muic" > + > Example: > #include > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 662ae0d..1c05ea0 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = { > .name = "max77693-charger", > .of_compatible = "maxim,max77693-charger", > }, > - { .name = "max77693-muic", }, > + { > + .name = "max77693-muic", > + .of_compatible = "maxim,max77693-muic", > + }, > { > .name = "max77693-haptic", > .of_compatible = "maxim,max77693-haptic", > -- > 2.7.4 >