Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbdHVMDn (ORCPT ); Tue, 22 Aug 2017 08:03:43 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:37699 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932499AbdHVMDl (ORCPT ); Tue, 22 Aug 2017 08:03:41 -0400 Subject: Re: [PATCH] ravb: make mdiobb_ops const To: Bhumika Goyal , julia.lawall@lip6.fr, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1503389282-17369-1-git-send-email-bhumirks@gmail.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <1f074a7c-0d3a-e569-4400-c50d967e550c@cogentembedded.com> Date: Tue, 22 Aug 2017 15:03:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503389282-17369-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 577 Lines: 19 Hello! On 08/22/2017 11:08 AM, Bhumika Goyal wrote: > Make these const as they are only stored in a const field of a > mdiobb_ctrl structure. > Signed-off-by: Bhumika Goyal > --- > drivers/net/ethernet/renesas/ravb_main.c | 2 +- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) If you're fixing both Renesas drivers at once, your subject should be "renesas: make mdiobb_ops const". With that fixed, you have my: Acked-by: Sergei Shtylyov MBR, Sergei