Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932703AbdHVMHB (ORCPT ); Tue, 22 Aug 2017 08:07:01 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35949 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932427AbdHVMG7 (ORCPT ); Tue, 22 Aug 2017 08:06:59 -0400 MIME-Version: 1.0 In-Reply-To: <1f074a7c-0d3a-e569-4400-c50d967e550c@cogentembedded.com> References: <1503389282-17369-1-git-send-email-bhumirks@gmail.com> <1f074a7c-0d3a-e569-4400-c50d967e550c@cogentembedded.com> From: Geert Uytterhoeven Date: Tue, 22 Aug 2017 14:06:58 +0200 X-Google-Sender-Auth: fVJ-ZD-fh_geFqNUOY4C4h3kE1k Message-ID: Subject: Re: [PATCH] ravb: make mdiobb_ops const To: Sergei Shtylyov Cc: Bhumika Goyal , Julia Lawall , "netdev@vger.kernel.org" , Linux-Renesas , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 28 On Tue, Aug 22, 2017 at 2:03 PM, Sergei Shtylyov wrote: > On 08/22/2017 11:08 AM, Bhumika Goyal wrote: >> Make these const as they are only stored in a const field of a >> mdiobb_ctrl structure. > >> Signed-off-by: Bhumika Goyal >> --- >> drivers/net/ethernet/renesas/ravb_main.c | 2 +- >> drivers/net/ethernet/renesas/sh_eth.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > If you're fixing both Renesas drivers at once, your subject should be > "renesas: make mdiobb_ops const". With that fixed, you have my: "net: renesas: make mdiobb_ops const"? There are plenty of other Renesas-specific drivers spread all over the tree. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds