Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932751AbdHVMXT (ORCPT ); Tue, 22 Aug 2017 08:23:19 -0400 Received: from ozlabs.org ([103.22.144.67]:51663 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932427AbdHVMXR (ORCPT ); Tue, 22 Aug 2017 08:23:17 -0400 Date: Tue, 22 Aug 2017 22:23:13 +1000 From: Anton Blanchard To: Arnd Bergmann Cc: "Theodore Ts'o" , Andreas Dilger , Kees Cook , Andrew Morton , Jan Kara , Chandan Rajendra , linux-ext4@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 1/2] ext4: fix warning about stack corruption Message-ID: <20170822222313.468ee7aa@kryten> In-Reply-To: References: <20170726185219.GA57833@beast> <20170801120438.1582336-1-arnd@arndb.de> <20170822210849.0edb91cc@kryten> X-Mailer: Mutt/1.8.0 (2017-02-23) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 416 Lines: 14 > > Unfortunately it doesn't appear to work, at least with ppc64le > > clang: > > > > fs/ext4/mballoc.c:2303:17: error: fields must have a constant size: > > 'variable length array in structure' extension will never be > > supported ext4_grpblk_t counters[blocksize_bits + 2]; > > My fix for this is in the ext4/dev branch in linux-next, I hope it > still makes it into v4.13. Thanks Arnd, I see it now. Anton