References: <20170821152128.14418-1-brendan.jackman@arm.com> <20170821152128.14418-3-brendan.jackman@arm.com> <20170821211400.GF32112@worktop.programming.kicks-ass.net> <CAJWu+ooBRXcND26JDvjvR-gGNWSmnV-adnLfy3HAQn23q_xqAg@mail.gmail.com> <87efs33mzl.fsf@arm.com> <20170822110300.lcpzyzgzqshdv7df@hirez.programming.kicks-ass.net>
User-agent: mu4e 0.9.17; emacs 25.1.1
From: Brendan Jackman <brendan.jackman@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andres Oportus <andresoportus@google.com>,
        Ingo Molnar <mingo@redhat.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH 2/2] sched/fair: Fix use of NULL with find_idlest_group
Message-ID: <87a82r3h4y.fsf@arm.com>
In-reply-to: <20170822110300.lcpzyzgzqshdv7df@hirez.programming.kicks-ass.net>
Date: Tue, 22 Aug 2017 13:46:13 +0100
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 716
Lines: 19


On Tue, Aug 22 2017 at 11:03, Peter Zijlstra wrote:
> On Tue, Aug 22, 2017 at 11:39:26AM +0100, Brendan Jackman wrote:
>
>> However the code movement helps - I'll combine it with Vincent's
>> suggestions and post a v2.
>
> Please also split into multiple patches, as I feel this 2/2 does too
> many things. Fixing that this_*_load initialization stuff for instance
> could be a separate patch.

Sure. It was initially multiple patches but there were confusing
dependencies between them, so I squashed it. I don' think that will be a
problem in light of the new suggestions from you & Vincent.

> And unlike what I did, do the whole code movement as a pure code
> movement, without any additional changes.

Will do.