Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932930AbdHVNEe (ORCPT ); Tue, 22 Aug 2017 09:04:34 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:33207 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932867AbdHVNEc (ORCPT ); Tue, 22 Aug 2017 09:04:32 -0400 MIME-Version: 1.0 In-Reply-To: <2f883a8a-5402-5625-bada-bcfed53c098e@gmail.com> References: <1501489333-23145-1-git-send-email-zhiyong.tao@mediatek.com> <1501489333-23145-3-git-send-email-zhiyong.tao@mediatek.com> <2f883a8a-5402-5625-bada-bcfed53c098e@gmail.com> From: Linus Walleij Date: Tue, 22 Aug 2017 15:04:31 +0200 Message-ID: Subject: Re: [PATCH 2/3] arm64: dts: mt2712: add pintcrl device node. To: Matthias Brugger Cc: Zhiyong Tao , Rob Herring , Mark Rutland , srv_heupstream@mediatek.com, Liguo Zhang , "Joe.C" , hongkun.cao@mediatek.com, Biao Huang , YT Shen , Hongzhou Yang , Erin Lo , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 522 Lines: 20 On Mon, Aug 14, 2017 at 5:23 PM, Matthias Brugger wrote: > On 07/31/2017 10:22 AM, Zhiyong Tao wrote: >> >> The commit includes two change: >> 1)add pintcrl device node for mt2712. >> 2)add pinfunc file for mt2712. >> >> Signed-off-by: Zhiyong Tao >> --- >> arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1014 >> +++++++++++++++++++++++++ > > > Shouldn't this file be in include/dt-bindings/pinctrl? Only if it is also #included in the driver. Yours, Linus Walleij