Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932826AbdHVNKv (ORCPT ); Tue, 22 Aug 2017 09:10:51 -0400 Received: from mail-oi0-f48.google.com ([209.85.218.48]:34274 "EHLO mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932657AbdHVNKt (ORCPT ); Tue, 22 Aug 2017 09:10:49 -0400 MIME-Version: 1.0 In-Reply-To: <1502319087-23396-1-git-send-email-yamada.masahiro@socionext.com> References: <1502319087-23396-1-git-send-email-yamada.masahiro@socionext.com> From: Linus Walleij Date: Tue, 22 Aug 2017 15:10:48 +0200 Message-ID: Subject: Re: [PATCH] gpio: brcmstb: check return value of gpiochip_irqchip_add() To: Masahiro Yamada Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Brian Norris , bcm-kernel-feedback-list , Florian Fainelli , Gregory Fong , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 295 Lines: 12 On Thu, Aug 10, 2017 at 12:51 AM, Masahiro Yamada wrote: > Because gpiochip_irqchip_add() may fail, its return value should > be checked. > > Signed-off-by: Masahiro Yamada Patch applied with Gregory's ACK. Yours, Linus Walleij