Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933021AbdHVOVQ (ORCPT ); Tue, 22 Aug 2017 10:21:16 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49498 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510AbdHVOVO (ORCPT ); Tue, 22 Aug 2017 10:21:14 -0400 Date: Tue, 22 Aug 2017 15:21:11 +0100 From: Mark Brown To: Donglin Peng Cc: Jeffy Chen , linux-kernel@vger.kernel.org, dgreid@chromium.org, Heiko =?iso-8859-1?Q?St=FCbner?= , briannorris@chromium.org, mengdong.lin@linux.intel.com, mka@chromium.org, lars@metafoo.de, dianders@chromium.org, Jaroslav Kysela , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai Message-ID: <20170822142111.zlosryhkyi75htod@sirena.org.uk> References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-3-jeffy.chen@rock-chips.com> <20170822140255.t2wfwkjr67v3eoxu@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6apki3taflv3xvuq" Content-Disposition: inline In-Reply-To: X-Cookie: Available while quantities last. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 32 --6apki3taflv3xvuq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote: > On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown wrote: > > We should be already verifying that drivers have a name, we assume one > > elsewhere. > But I can't find any codes that set or check dai_driver->name in > function snd_soc_register_codec or snd_soc_register_component. We should fix that then. --6apki3taflv3xvuq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmcPdYACgkQJNaLcl1U h9A77gf/XSS0s9fUUdiWXihLx8CQtL3uUO/Q388wF/LaECfQUlvkHfVOa4SXfgiG No0pQfYSpC8sI/GZxZWOWKE/UGZ/qJg1ezHMM3VFlysy4MkgiOxqK2UyJpLxGxVM x8kUrdohqoZLTdIGvbYGVVYLYvUShmiNDxZsgRk0HF4OmpZ3NZgduQj2hvJKDuK9 MzgwvwfLxc4VVkEDErl4ClS7AGN6YmjJy1qVy3gJtSXb32IxU4VfKDE2g8YngOZf gNXA3GzKKvbMjpyMET485ipavv3YAK79RkTLkmDWr8AJlx8lFcZ46zaW3TUEflVb t70YoxRBF0sFI14Lj/hWAxjbZfL8ag== =HmHS -----END PGP SIGNATURE----- --6apki3taflv3xvuq--