Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932894AbdHVO1C (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 10:27:02 -0400
Received: from mx2.suse.de ([195.135.220.15]:44434 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S932513AbdHVO1B (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 10:27:01 -0400
Date: Tue, 22 Aug 2017 16:26:59 +0200
Message-ID: <s5h8tib8yq4.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Donglin Peng" <dolinux.peng@gmail.com>, <alsa-devel@alsa-project.org>,
        <briannorris@chromium.org>, <dgreid@chromium.org>,
        <dianders@chromium.org>, <mka@chromium.org>,
        "Liam Girdwood" <lgirdwood@gmail.com>, <mengdong.lin@linux.intel.com>,
        <lars@metafoo.de>, "Jaroslav Kysela" <perex@perex.cz>,
        "Jeffy Chen" <jeffy.chen@rock-chips.com>,
        =?UTF-8?B?IkhlaWtvIFN0w7xibmVyIg==?= <heiko@sntech.de>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai
In-Reply-To: <20170822142111.zlosryhkyi75htod@sirena.org.uk>
References: <20170822075729.8438-1-jeffy.chen@rock-chips.com>
        <20170822075729.8438-3-jeffy.chen@rock-chips.com>
        <CAErzpmtbbWbt28KPaFLVdwzuWy3A7se7_WBN8q6aJrHLbtT-LQ@mail.gmail.com>
        <20170822140255.t2wfwkjr67v3eoxu@sirena.org.uk>
        <CAErzpmsg9fi0-ukHG13-dy2r02892h+oPXmtsusCbu-xLzazFQ@mail.gmail.com>
        <20170822142111.zlosryhkyi75htod@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 615
Lines: 19

On Tue, 22 Aug 2017 16:21:11 +0200,
Mark Brown wrote:
> 
> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
> > On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@kernel.org> wrote:
> 
> > > We should be already verifying that drivers have a name, we assume one
> > > elsewhere.
> 
> > But I can't find any codes that set or check dai_driver->name in
> > function snd_soc_register_codec or snd_soc_register_component.
> 
> We should fix that then.

Hmm, as far as I read the code, the NULL dai driver name is valid for
a single component.  The dai name is determined by fmt_single_name().


Takashi