Message-ID: <599C420A.80601@rock-chips.com>
Date: Tue, 22 Aug 2017 22:39:06 +0800
From: jeffy <jeffy.chen@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0
MIME-Version: 1.0
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
CC: Donglin Peng <dolinux.peng@gmail.com>, alsa-devel@alsa-project.org,
        briannorris@chromium.org, dgreid@chromium.org, dianders@chromium.org,
        mka@chromium.org, Liam Girdwood <lgirdwood@gmail.com>,
        mengdong.lin@linux.intel.com, lars@metafoo.de,
        Jaroslav Kysela <perex@perex.cz>,
        =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= <heiko@sntech.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name
 in snd_soc_find_dai
References: <20170822075729.8438-1-jeffy.chen@rock-chips.com> <20170822075729.8438-3-jeffy.chen@rock-chips.com> <CAErzpmtbbWbt28KPaFLVdwzuWy3A7se7_WBN8q6aJrHLbtT-LQ@mail.gmail.com> <20170822140255.t2wfwkjr67v3eoxu@sirena.org.uk> <CAErzpmsg9fi0-ukHG13-dy2r02892h+oPXmtsusCbu-xLzazFQ@mail.gmail.com> <20170822142111.zlosryhkyi75htod@sirena.org.uk> <s5h8tib8yq4.wl-tiwai@suse.de>
In-Reply-To: <s5h8tib8yq4.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 773
Lines: 28

Hi guys,

On 08/22/2017 10:26 PM, Takashi Iwai wrote:
> On Tue, 22 Aug 2017 16:21:11 +0200,
> Mark Brown wrote:
>>
>> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
>>> On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@kernel.org> wrote:
>>
>>>> We should be already verifying that drivers have a name, we assume one
>>>> elsewhere.
>>
>>> But I can't find any codes that set or check dai_driver->name in
>>> function snd_soc_register_codec or snd_soc_register_component.
>>
>> We should fix that then.
>
> Hmm, as far as I read the code, the NULL dai driver name is valid for
> a single component.  The dai name is determined by fmt_single_name().
>
>
> Takashi
>
>
sorry, i though that is checked too... new patch is coming, thanks for 
noticing :)
>