Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933047AbdHVOnG (ORCPT ); Tue, 22 Aug 2017 10:43:06 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:38934 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932913AbdHVOnF (ORCPT ); Tue, 22 Aug 2017 10:43:05 -0400 Subject: Re: [PATCH] selftests: timers: Fix run_destructive_tests target to handle skipped tests To: Benjamin Gaignard , John Stultz Cc: Shuah Khan , Thomas Gleixner , Stephen Boyd , lkml , linux-kselftest@vger.kernel.org, Shuah Khan References: <20170817224845.29630-1-shuahkh@osg.samsung.com> From: Shuah Khan Message-ID: Date: Tue, 22 Aug 2017 08:42:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 48 On 08/20/2017 07:08 AM, Benjamin Gaignard wrote: > 2017-08-19 2:36 GMT+02:00 John Stultz : >> On Thu, Aug 17, 2017 at 3:48 PM, Shuah Khan wrote: >>> When a test exits with skip exit code of 4, "make run_destructive_tests" >>> halts testing. Fix run_destructive_tests target to handle error exit codes. >>> >>> Reported-by: John Stultz >>> Signed-off-by: Shuah Khan >>> --- >>> tools/testing/selftests/timers/Makefile | 26 +++++++++++++------------- >>> 1 file changed, 13 insertions(+), 13 deletions(-) >>> >>> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile >>> index c805ab048d26..6c1327278d5f 100644 >>> --- a/tools/testing/selftests/timers/Makefile >>> +++ b/tools/testing/selftests/timers/Makefile >>> @@ -13,20 +13,20 @@ TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew >>> >>> include ../lib.mk >>> >>> +define RUN_DESTRUCTIVE_TESTS >>> + @for TEST in $(TEST_GEN_PROGS_EXTENDED); do \ >>> + BASENAME_TEST=`basename $$TEST`; \ >>> + if [ ! -x $$BASENAME_TEST ]; then \ >>> + echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\ >>> + echo "selftests: $$BASENAME_TEST [FAIL]"; \ >>> + else \ >>> + cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests: $$BASENAME_TEST [FAIL]"; cd -;\ >>> + fi; \ >>> + done; >>> +endef >> >> One more on this... you might remove rtctest_setdate from the >> TEST_GEN_PROGS_EXTENDED list, since it too requires arguments to test, >> and it wasn't a part of run_destructive_tests previously. >> >> I see Benjamin added this test not long ago, but I'm not sure exactly >> how he expects it to be run (just manually?). > > Yes run this test manually is enough > Thanks I will make the change so that rtctest_setdate isn't included in the destructive tests target and stays in the install so it gets installed on the target test system. Will send the patch to you both. thanks, -- Shuah