Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbdHVPvM (ORCPT ); Tue, 22 Aug 2017 11:51:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59010 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdHVPvL (ORCPT ); Tue, 22 Aug 2017 11:51:11 -0400 Date: Tue, 22 Aug 2017 08:51:15 -0700 From: Greg Kroah-Hartman To: Chen-Yu Tsai Cc: Ben Hutchings , linux-kernel , stable@vger.kernel.org, Icenowy Zheng , Linus Walleij Subject: Re: [PATCH 4.12 55/65] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Message-ID: <20170822155115.GC10872@kroah.com> References: <20170815011942.395714306@linuxfoundation.org> <20170815011944.581180081@linuxfoundation.org> <1503086826.3688.30.camel@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 32 On Tue, Aug 22, 2017 at 05:11:30PM +0800, Chen-Yu Tsai wrote: > On Sat, Aug 19, 2017 at 4:07 AM, Ben Hutchings wrote: > > On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote: > >> 4.12-stable review patch. If anyone has any objections, please let me know. > >> > >> ------------------ > >> > >> From: Icenowy Zheng > >> > >> commit d81ece747d8727bb8b1cfc9a20dbe62f09a4e35a upstream. > >> > >> The PH16 pin has a function with mux id 0x5, which is the DET pin of the > >> "sim" (smart card reader) IP block. > >> > >> This function is missing in old versions of A10/A20 SoCs' datasheets and > >> user manuals, so it's also missing in the old drivers. The newest A10 > >> Datasheet V1.70 and A20 Datasheet V1.41 contain this pin function, and > >> it's discovered during implementing R40 pinctrl driver. > >> > >> Add it to the driver. As we now merged A20 pinctrl driver to the A10 > >> one, we need to only fix the A10 driver now. > > > > That happened after 4.12, so I think for stable the same change should > > be applied in drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c. > > Indeed. Should we send a backported patch? Yes, please do. thanks, greg k-h