Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751292AbdHVQP1 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 12:15:27 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46444 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751043AbdHVQP0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 12:15:26 -0400
Subject: Re: [PATCH] xen/events: events_fifo: Don't use {get,put}_cpu() in
 xen_evtchn_fifo_init()
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xen.org
References: <20170817161453.19318-1-julien.grall@arm.com>
 <651ecfe9-fafa-de8c-3d1c-345b136aa366@oracle.com>
 <1f568982-1518-2f7b-64dc-cd94c1943c1d@arm.com>
Cc: jgross@suse.com, linux-kernel@vger.kernel.org
From: Julien Grall <julien.grall@arm.com>
Message-ID: <c2866f89-32b9-a7ce-13c2-32b839dae659@arm.com>
Date: Tue, 22 Aug 2017 17:15:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1f568982-1518-2f7b-64dc-cd94c1943c1d@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3307
Lines: 78

Hi,

Gentle ping. This patch was reviewed but not queued. Are we waiting for 
other reviewed?

Cheers,

On 18/08/17 11:15, Julien Grall wrote:
> Hi Boris,
>
> On 17/08/17 18:36, Boris Ostrovsky wrote:
>> On 08/17/2017 12:14 PM, Julien Grall wrote:
>>> When booting Linux as Xen guest with CONFIG_DEBUG_ATOMIC, the following
>>> splat appears:
>>>
>>> [    0.002323] Mountpoint-cache hash table entries: 1024 (order: 1,
>>> 8192 bytes)
>>> [    0.019717] ASID allocator initialised with 65536 entries
>>> [    0.020019] xen:grant_table: Grant tables using version 1 layout
>>> [    0.020051] Grant table initialized
>>> [    0.020069] BUG: sleeping function called from invalid context at
>>> /data/src/linux/mm/page_alloc.c:4046
>>> [    0.020100] in_atomic(): 1, irqs_disabled(): 0, pid: 1, name:
>>> swapper/0
>>> [    0.020123] no locks held by swapper/0/1.
>>> [    0.020143] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-rc5 #598
>>> [    0.020166] Hardware name: FVP Base (DT)
>>> [    0.020182] Call trace:
>>> [    0.020199] [<ffff00000808a5c0>] dump_backtrace+0x0/0x270
>>> [    0.020222] [<ffff00000808a95c>] show_stack+0x24/0x30
>>> [    0.020244] [<ffff000008c1ef20>] dump_stack+0xb8/0xf0
>>> [    0.020267] [<ffff0000081128c0>] ___might_sleep+0x1c8/0x1f8
>>> [    0.020291] [<ffff000008112948>] __might_sleep+0x58/0x90
>>> [    0.020313] [<ffff0000082171b8>] __alloc_pages_nodemask+0x1c0/0x12e8
>>> [    0.020338] [<ffff00000827a110>] alloc_page_interleave+0x38/0x88
>>> [    0.020363] [<ffff00000827a904>] alloc_pages_current+0xdc/0xf0
>>> [    0.020387] [<ffff000008211f38>] __get_free_pages+0x28/0x50
>>> [    0.020411] [<ffff0000086566a4>]
>>> evtchn_fifo_alloc_control_block+0x2c/0xa0
>>> [    0.020437] [<ffff0000091747b0>] xen_evtchn_fifo_init+0x38/0xb4
>>> [    0.020461] [<ffff0000091746c0>] xen_init_IRQ+0x44/0xc8
>>> [    0.020484] [<ffff000009128adc>] xen_guest_init+0x250/0x300
>>> [    0.020507] [<ffff000008083974>] do_one_initcall+0x44/0x130
>>> [    0.020531] [<ffff000009120df8>] kernel_init_freeable+0x120/0x288
>>> [    0.020556] [<ffff000008c31ca8>] kernel_init+0x18/0x110
>>> [    0.020578] [<ffff000008083710>] ret_from_fork+0x10/0x40
>>> [    0.020606] xen:events: Using FIFO-based ABI
>>> [    0.020658] Xen: initializing cpu0
>>> [    0.027727] Hierarchical SRCU implementation.
>>> [    0.036235] EFI services will not be available.
>>> [    0.043810] smp: Bringing up secondary CPUs ...
>>>
>>> This is because get_cpu() in xen_evtchn_fifo_init() will disable
>>> preemption, but __get_free_page() might sleep (GFP_ATOMIC is not set).
>>>
>>> xen_evtchn_fifo_init() will always be called before SMP is initialized,
>>> so {get,put}_cpu() could be replaced by a simple smp_processor_id().
>>
>> On x86 this will be called out of init_IRQ(), which is already preceded
>> by preempt_disable().
>
> Well the main problem is preempt_disable() itself. in_atomic() will
> check preempt_count and return 1 if it is non-zero.
>
> __get_free_page might sleep if GFP_ATOMIC is not set and therefore you
> will see the splat when CONFIG_DEBUG_ATOMIC is enabled. However, those
> checks don't happen before the scheduler is setup. Hence why you don't
> see the error on x86.
>
> Cheers,
>
>>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>>
>

-- 
Julien Grall