From: Bernardo Innocenti <bernie@develer.com>
Organization: Develer
To: Andrea Arcangeli <andrea@suse.de>
Subject: Re: [PATCH] Kill div64.h dupes, parenthesize do_div() macro params
Date: Wed, 2 Jul 2003 09:28:38 +0200
User-Agent: KMail/1.5.9
References: <200307020232.20726.bernie@develer.com> <200307020852.17782.bernie@develer.com> <20030702071919.GP3040@dualathlon.random>
In-Reply-To: <20030702071919.GP3040@dualathlon.random>
Cc: Peter Chubb <peter@chubb.wattle.id.au>, Andrew Morton <akpm@digeo.com>,
       linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@transmeta.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200307020928.38830.bernie@develer.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1088
Lines: 33

On Wednesday 02 July 2003 09:19, you wrote:
 > On Wed, Jul 02, 2003 at 08:52:17AM +0200, Bernardo Innocenti wrote:
 > > + *	static inline uint32_t do_div(uint64_t &n, uint32_t base)
 >
 > c++ ;)

 Oops! Shall I send a new patch? ;-)

 > > +# error do_div() does not yet support the C64
 >
 > ;)
 >
 > this new version looks good to me since it will fix bugs and it's not
 > only a cleanup avoiding code duplication. thanks.

 The previous patch was not just a cleanup: it actually added parenthes
that were missing around parameters in many do_div() variants. Guess
what happened when shrink_slab() did this (pages = 0):

   do_div(delta, pages + 1); /* Ouch! */

-- 
  // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/

Please don't send Word attachments - http://www.gnu.org/philosophy/no-word-attachments.html


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/