Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204AbdHVSZ6 (ORCPT ); Tue, 22 Aug 2017 14:25:58 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35520 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbdHVSZy (ORCPT ); Tue, 22 Aug 2017 14:25:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <37D7C6CF3E00A74B8858931C1DB2F0775378761B@SHSMSX103.ccr.corp.intel.com> <20170818122339.24grcbzyhnzmr4qw@techsingularity.net> <37D7C6CF3E00A74B8858931C1DB2F077537879BB@SHSMSX103.ccr.corp.intel.com> <20170818144622.oabozle26hasg5yo@techsingularity.net> <37D7C6CF3E00A74B8858931C1DB2F07753787AE4@SHSMSX103.ccr.corp.intel.com> <20170818185455.qol3st2nynfa47yc@techsingularity.net> <20170821183234.kzennaaw2zt2rbwz@techsingularity.net> <37D7C6CF3E00A74B8858931C1DB2F07753788B58@SHSMSX103.ccr.corp.intel.com> <37D7C6CF3E00A74B8858931C1DB2F0775378A24A@SHSMSX103.ccr.corp.intel.com> From: Linus Torvalds Date: Tue, 22 Aug 2017 11:25:52 -0700 X-Google-Sender-Auth: oiclECG6wV4WT960vbDoX1VyaZs Message-ID: Subject: Re: [PATCH 1/2] sched/wait: Break up long wake list walk To: "Liang, Kan" Cc: Mel Gorman , Mel Gorman , "Kirill A. Shutemov" , Tim Chen , Peter Zijlstra , Ingo Molnar , Andi Kleen , Andrew Morton , Johannes Weiner , Jan Kara , linux-mm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 575 Lines: 15 On Tue, Aug 22, 2017 at 11:19 AM, Linus Torvalds wrote: > > So I propose testing the attached trivial patch. It may not do > anything at all. But the existing code is actually doing extra work > just to be fragile, in case the scenario above can happen. Side note: the patch compiles for me. But that is literally ALL the testing it has gotten. I spent more time writing that email trying to explain what my thinking was about that patch, than I spent anywhere else on that patch. So it may be garbage. Caveat probator. Linus